Remove pthreads and use C++11 mutexes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was also a lot of OpenSSL compatibility stuff hanging around that was totally unneeded calls, so remove that as well.
davidben
approved these changes
Dec 23, 2016
There was a problem hiding this comment.
lgtm with the caveat that I'm not very familiar with C++11's threading bits. I think most of our projects ban it, but it seems largely because they all have existing threading libraries.
If it works for all places Conscrypt is to be embedded, it's probably a good idea.
| { | ||
| SSL_load_error_strings(); | ||
| ERR_load_crypto_strings(); | ||
| SSL_library_init(); |
There was a problem hiding this comment.
This (SSL_library_init, which just calls CRYPTO_library_init) isn't quiiiite a no-op in an BORINGSSL_NO_STATIC_INITIALIZER build. That said, Chromium is the only thing that builds in that way because it's allergic to static initializers, so it's probably fine to omit it? Your call.
|
I restored the |
davidben
approved these changes
Dec 27, 2016
kruton
force-pushed
the
pthread-removal
branch
from
fde0c69
to
c514a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was also a lot of OpenSSL compatibility stuff hanging around that
was totally unneeded calls, so remove that as well.