Fix-up sslSelect logic for Windows #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Windows to work with parity for existing code. Interrupting works and all the tests pass. In the future, the #ifdefs could be split out into a different file so we could include more strategies such as epoll or kqueue in the future. However, this is only selecting on two objects. Change-Id: Ia5c58b72e78aeac129f2987b99ce2a6d75448d32
nmittler
reviewed
Jan 12, 2017
|
|
||
| return count; | ||
| } | ||
| int vasprintf(char **ret, const char *format, va_list args); |
There was a problem hiding this comment.
I think you need to revert this now that I just merged #38
Change-Id: Ie88e48096ff8e78936c2674747fbc7131a7bc61d
|
Yeah, I was writing this in a Windows VM with Notepad. I can clean it up in a real editor :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Windows to work with parity for existing code. Interrupting
works and all the tests pass.
In the future, the #ifdefs could be split out into a different file
so we could include more strategies such as epoll or kqueue in the
future. However, this is only selecting on two objects.
Change-Id: Ia5c58b72e78aeac129f2987b99ce2a6d75448d32