Commit 794b1b7
Re-number enum values part 2
- Makes enum values within an implementation-specific range packed
at the front.
- Tag emscripten-specific enum values.
- Generate Dawn webgpu{_cpp}.h headers with all tags enabled except
"upstream". This means we generate Emscripten-only things inside
the header as well so the header can be used for either native
or web. In native, Dawn would report these features as not
supported. Currently the only such feature was the surface descriptor
for HTML canvas element. Previously, it was specified in dawn.json
without the "emscripten" tag, so Dawn headers already included
it.
- Remove the emscripten-only onSubmittedWorkDone function. This is
necessary to avoid a function type conflict with the new function.
The Emscripten signature was already changed in
emscripten-core/emscripten#21299
- Update dawn native format utils to handle unknown enums. The header
has all the enums in it, but Dawn native doesn't know the Emscripten
enums.
Fixed: 42241083
Change-Id: I4774053d1718ad6302ce2e4302ad8690787c10e6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/196174
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>1 parent 7a53b7c commit 794b1b7
File tree
4 files changed
+28
-28
lines changed- generator
- templates/dawn/native
- src/dawn
- tools/android
4 files changed
+28
-28
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | 97 | | |
99 | 98 | | |
100 | 99 | | |
| |||
1204 | 1203 | | |
1205 | 1204 | | |
1206 | 1205 | | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
1207 | 1213 | | |
1208 | 1214 | | |
1209 | 1215 | | |
| |||
1212 | 1218 | | |
1213 | 1219 | | |
1214 | 1220 | | |
1215 | | - | |
| 1221 | + | |
1216 | 1222 | | |
1217 | 1223 | | |
1218 | 1224 | | |
| |||
1225 | 1231 | | |
1226 | 1232 | | |
1227 | 1233 | | |
1228 | | - | |
| 1234 | + | |
1229 | 1235 | | |
1230 | 1236 | | |
1231 | 1237 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
| 94 | + | |
| 95 | + | |
94 | 96 | | |
95 | | - | |
96 | | - | |
97 | 97 | | |
| 98 | + | |
98 | 99 | | |
99 | 100 | | |
100 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2919 | 2919 | | |
2920 | 2920 | | |
2921 | 2921 | | |
2922 | | - | |
2923 | | - | |
2924 | | - | |
2925 | | - | |
2926 | | - | |
2927 | | - | |
2928 | | - | |
2929 | | - | |
2930 | | - | |
2931 | 2922 | | |
2932 | 2923 | | |
2933 | 2924 | | |
| |||
3851 | 3842 | | |
3852 | 3843 | | |
3853 | 3844 | | |
| 3845 | + | |
3854 | 3846 | | |
3855 | 3847 | | |
3856 | 3848 | | |
| |||
3878 | 3870 | | |
3879 | 3871 | | |
3880 | 3872 | | |
3881 | | - | |
| 3873 | + | |
3882 | 3874 | | |
3883 | 3875 | | |
3884 | 3876 | | |
| |||
3956 | 3948 | | |
3957 | 3949 | | |
3958 | 3950 | | |
3959 | | - | |
3960 | | - | |
3961 | | - | |
3962 | | - | |
3963 | | - | |
3964 | | - | |
3965 | | - | |
3966 | | - | |
3967 | | - | |
3968 | | - | |
3969 | | - | |
| 3951 | + | |
| 3952 | + | |
| 3953 | + | |
| 3954 | + | |
3970 | 3955 | | |
3971 | 3956 | | |
3972 | 3957 | | |
| 3958 | + | |
| 3959 | + | |
| 3960 | + | |
| 3961 | + | |
| 3962 | + | |
| 3963 | + | |
| 3964 | + | |
| 3965 | + | |
| 3966 | + | |
3973 | 3967 | | |
3974 | 3968 | | |
3975 | 3969 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
185 | 184 | | |
186 | 185 | | |
187 | 186 | | |
| |||
0 commit comments