Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the anonymous union in SamplerParams #7104

Merged
merged 1 commit into from
Aug 25, 2023
Merged

remove the anonymous union in SamplerParams #7104

merged 1 commit into from
Aug 25, 2023

Conversation

pixelflinger
Copy link
Collaborator

  • we don't rely on it being 32-bits

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Aug 23, 2023
@pixelflinger
remove the anonymous union in SamplerParams
63ff235 
- don't rely on it being 32-bits
- update the jni code to store SamplerParams in a long (64 bits)
  instead of a int. This gives us some future-proofing of the java side.
@pixelflinger pixelflinger merged commit 97f20af into main Aug 25, 2023
11 checks passed
@pixelflinger pixelflinger deleted the ma/samplers branch August 25, 2023 04:36
@suzp1984 suzp1984 mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poweifeng poweifeng poweifeng approved these changes

@romainguy romainguy Awaiting requested review from romainguy

@bejado bejado Awaiting requested review from bejado

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixelflinger @poweifeng