Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manylinux magika wheel does not install on ubuntu 20.04 with pip #781

Closed
reyammer opened this issue Nov 1, 2024 · 4 comments
Closed

manylinux magika wheel does not install on ubuntu 20.04 with pip #781

reyammer opened this issue Nov 1, 2024 · 4 comments
Labels
python Pull requests that update Python package

Comments

@reyammer
Copy link
Collaborator

reyammer commented Nov 1, 2024

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.6 LTS
Release:        20.04
Codename:       focal

$ cat /proc/cpuinfo | grep vendor_id
vendor_id       : AuthenticAMD

$ python3  --version
Python 3.8.10

$ dpkg -l | grep libc6:amd64
ii  libc6:amd64                        2.31-0ubuntu9.16                  amd64        GNU C Library: Shared libraries

$ pip install ./magika-0.6.0rc1-py3-none-manylinux_2_28_x86_64.whl
ERROR: magika-0.6.0rc1-py3-none-manylinux_2_28_x86_64.whl is not a supported wheel on this platform.

Unfortunately pip does not tell you why (see pypa/pip#10793).

What's even weirder: the wheel installs correctly (and without warnings) with uv on the same VM.

Given the metadata above, the wheel should actually be compatible.

You can get the wheel here: https://github.com/google/magika/actions/runs/11631673973

The test VM is just an ubuntu 20.04 VM on GCE.

Thoughts @ia0 @invernizzi?

@reyammer reyammer added the python Pull requests that update Python package label Nov 1, 2024
ia0 added a commit to ia0/magika that referenced this issue Nov 2, 2024
DO NOT MERGE. This is a test for google#781.
ia0 added a commit to ia0/magika that referenced this issue Nov 2, 2024
DO NOT MERGE. This is a test for google#781.
ia0 added a commit to ia0/magika that referenced this issue Nov 2, 2024
DO NOT MERGE. This is a test for google#781.
ia0 added a commit to ia0/magika that referenced this issue Nov 2, 2024
DO NOT MERGE. This is a test for google#781.
ia0 added a commit to ia0/magika that referenced this issue Nov 2, 2024
DO NOT MERGE. This is a test for google#781.
ia0 added a commit to ia0/magika that referenced this issue Nov 2, 2024
DO NOT MERGE. This is a test for google#781.
ia0 added a commit to ia0/magika that referenced this issue Nov 2, 2024
DO NOT MERGE. This is a test for google#781.
@ia0
Copy link
Member

ia0 commented Nov 2, 2024

The wheel also installs in the maturin container (see Run before script under Test wheels in #783). However the container doesn't seem to be Ubuntu 20.04 but a container with an old enough libc: quay.io/pypa/manylinux_2_28_x86_64:latest. It might be the python version: 3.11.9 in the maturin container and 3.8.10 for you.

@reyammer
Copy link
Collaborator Author

reyammer commented Nov 4, 2024

/cc @hauntsaninja maybe you know how to debug this a bit better? or maybe we are hitting a known issue with pip / manylinux?

@gaby
Copy link
Contributor

gaby commented Nov 4, 2024

@reyammer Python 3.8 is EOL since laet month. Is the plan to still support it?

Try doing a verbose install, maybe that says something

@reyammer
Copy link
Collaborator Author

reyammer commented Nov 4, 2024

It seems there is no way to get more info from pip, even with verbose (see pypa/pip#10793), BUT: using a more recent version of pip worked out!

On the old ubuntu VM I'm playing with, pip comes from the python3-pip deb package (20.0.2-5ubuntu1.11). But if I use a more recent version of pip, the wheel seems to install successfully!

Steps:

  • python3 -m pip install --upgrade pip
  • python3 -m pip install path/to/wheel.whl

So, everything seems working, closing this for now. We should have all we need to finally publish an -rc to pypi.

[About dropping support for 3.8: for now it's now supporting it is not creating issues, so I would leave everything as is until we run into problems?]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python package
Projects
None yet
Development

No branches or pull requests

3 participants