-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maturin workflow to generate wheels #747
Conversation
f8d2712
to
299f430
Compare
@reyammer So the conclusion is that |
Reopening this to test compiling ONNX Runtime from source. |
ffbaf3c
to
c6294c4
Compare
9c46b72
to
a2df5cc
Compare
Here are the wheels for examination. |
Here are the wheels. I checked the linux one and the versions (in wheel name, Rust CLI, and Python version) are correct. Not sure what else to check. The workflow anyway checks even more. |
About the wheels: yesterday I checked the linux one (but on a modern box) and the mac ones, and they worked! will add tests for the old ubuntu in a different PR. Other than this, this looks good! |
The only missing test is the wheel test in the container (thus for Linux). We already test everything else (including the CLI in the container). If you believe the wheel and python code could behave differently in the container, then it's worth looking into, otherwise I believe this PR should be sufficient. |
I should also have checked |
No description provided.