Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add support for "KHR_materials_clearcoat", "KHR_materials_transmission", "KHR_materials_sheen" #1778

Closed
rawwerks opened this issue Dec 21, 2020 · 5 comments
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue type: feature New feature or request

Comments

@rawwerks
Copy link

Description

There are three new PBR extensions that Khronos recently released that dramatically improve the ability to create photo-realistic GLTF files. https://gfxspeak.com/2020/12/03/physically-rendering-extensions/

Given that model-viewer supports GLTF, and that these 3 extensions are official extensions for GLTF 2.0, it would seem within the scope of this application to include the functionality to correctly display these new extensions: "KHR_materials_clearcoat", "KHR_materials_transmission", "KHR_materials_sheen"

https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos

Comparison

Comparison between Model Viewer (Left, extensions not supported) and Babylon (Right, extensions supported)

image

See example file at:
https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/ToyCar

Version

Whatever version is live at https://modelviewer.dev/editor/

Browser Affected

This is not a browser-specific issue.

OS

This is not an OS-specific issue.

@rawwerks
Copy link
Author

rawwerks commented Dec 22, 2020

@bsdorra @elalish - any implementation tips on KHR_materials_transmission since these extensions are hot off the press?

edit: this implementation tip from @MiiBond may be useful here as well: mrdoob/three.js#16977 (comment)

@elalish
Copy link
Collaborator

elalish commented Dec 28, 2020

Yes, you've already linked to the right place in three.js. Support in model-viewer will come via support in three. I believe clearcoat is already working, and sheen is partially there, but not hooked up to GLTFLoader. We definitely intend to support these extensions.

@elalish elalish added flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue type: feature New feature or request labels Dec 28, 2020
@donmccurdy
Copy link
Contributor

donmccurdy commented Jul 23, 2021

2/3 of these (clearcoat, transmission) have been in three.js for a bit now and I assume are working in model-viewer already? Although I'd add Volume and IOR to the list now. 😉

EDIT: Correction, it doesn't look like transmission is working just yet:

Screen Shot 2021-07-23 at 10 18 20 AM

@elalish
Copy link
Collaborator

elalish commented Jul 23, 2021

They should in the next release when we update three.js versions. You can test the current state of development with our editor. We're also working on getting some tests going for these extensions before we go trumpeting support.

@elalish
Copy link
Collaborator

elalish commented Aug 5, 2021

I'm going to call this fixed, as we have not just these extensions now with r131, but also ior, specular, and volume. I think sheen may not be totally supported yet and there could easily be some bugs in the others, but I'd rather track those as individual issues.

@elalish elalish closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants