You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit affects only mozc_tip{32,64}.dll build with debug mode.
There must be no behavior change in release build.
Currently 'Mozc_tsf_ui.log' is created only when NDEBUG is defined.
With this commit we stop creating it even when NDEBUG is defined.
This addresses a crash issue in debug builds discussed in google#1077.
See google#856 about why absl::LocalTimeZone cannot be used in Windows right
now.
Note that this commit may also help us diagnose google#1076, where
Windows.Storage.OneCore.dll
looks to be intercepting certain Win32 file I/O API calls in
AppContainer processes then trigger RoInitialize as needed.
Creating 'Mozc_tsf_ui.log' only in debug builds can make our debugging
more complicated.
This commit affects only mozc_tip{32,64}.dll build with debug mode.
There must be no behavior change in release build.
Currently 'Mozc_tsf_ui.log' is created only when NDEBUG is defined.
With this commit we stop creating it even when NDEBUG is defined.
This addresses a crash issue in debug builds discussed in google#1077.
See google#856 about why absl::LocalTimeZone cannot be used in Windows right
now.
Note that this commit may also help us diagnose google#1076, where
Windows.Storage.OneCore.dll
looks to be intercepting certain Win32 file I/O API calls in
AppContainer processes then trigger RoInitialize as needed.
Creating 'Mozc_tsf_ui.log' only in debug builds can make our debugging
more complicated.
Description
In short, acaa7af reintroduced the following issue as it internally triggers
RoInitialize()
.CoInitialize
may crash when loading or enabling Mozc in Windows #856Steps to reproduce
Steps to reproduce the behavior:
Mozc64.msi
Expected behavior
The test app does not crash at the step 3.
Actual behavior
The test app crashes at the step 3.
Version or commit-id
1d74ac4
Environment
Additional context
This does not affect release build as it is guarded with
NDEBUG
.mozc/src/base/log_file.cc
Lines 66 to 71 in 1d74ac4
The text was updated successfully, but these errors were encountered: