Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a build job for cabal new-build #212

Closed
2 tasks
judah opened this issue Aug 25, 2018 · 3 comments
Closed
2 tasks

Add a build job for cabal new-build #212

judah opened this issue Aug 25, 2018 · 3 comments

Comments

@judah
Copy link
Collaborator

judah commented Aug 25, 2018 •
edited by blackgnezdo
Loading

We should add a build job to our Travis config that confirms cabal new-build works.

TODO:

  • Add a separate build job that tests new-build in CI. This probably requires adding build-tool-depends to proto-lens-protobuf-types, proto-lens-combinators and proto-lens-tests.
  • Document that the build-tool-depends attribute is required for cabal new-build.
@hvr
Copy link

hvr commented Aug 29, 2018

Fyi, I've noticed

See also #110 (comment)

@judah
Copy link
Collaborator Author

judah commented Oct 2, 2019

For consistency, we should probably recommend using build-tool-depends for Stack as well as Cabal.

@judah judah mentioned this issue Oct 2, 2019
Closed
@judah judah mentioned this issue Oct 2, 2019
Closed
@judah
Copy link
Collaborator Author

judah commented Oct 22, 2019

Fixed by #356.

@judah judah closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@judah @hvr