Optional<int>.absent() != Optional<String>.absent() (#373)

google · Oct 16, 2017 · 052b652 · 052b652
1 parent 16c7fa2
commit 052b652
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/src/core/optional.dart b/lib/src/core/optional.dart
@@ -98,7 +98,7 @@ class Optional<T> extends IterableBase<T> {
   int get hashCode => _value.hashCode;
 
   /// Delegates to the underlying [value] operator==.
-  bool operator ==(o) => o is Optional && o._value == _value;
+  bool operator ==(o) => o is Optional<T> && o._value == _value;
 
   String toString() {
     return _value == null

diff --git a/test/core/optional_test.dart b/test/core/optional_test.dart
@@ -99,6 +99,10 @@ main() {
       expect(new Optional<int>.of(7), equals(new Optional<int>.of(7)));
       expect(new Optional<int>.fromNullable(null),
           equals(new Optional<int>.fromNullable(null)));
+      expect(
+          new Optional<int>.fromNullable(null) ==
+              new Optional<String>.fromNullable(null),
+          isFalse);
       expect(new Optional<int>.fromNullable(null),
           isNot(equals(new Optional<int>.of(7))));
       expect(new Optional<int>.of(7), isNot(equals(new Optional<int>.of(8))));