Merged
Conversation
The `update` method on the `set` is defined in the Starlark specification [1] but is not present in the starlark-go implementation. This change introduces this functionality. [1] https://github.com/bazelbuild/starlark/blob/master/spec.md#setupdate
Fixes from @adonovan in PR
adonovan
reviewed
Jan 27, 2025
adonovan
reviewed
Jan 27, 2025
starlark/library.go
Outdated
| switch v := arg.(type) { | ||
| receiverSet := b.Receiver().(*Set) | ||
|
|
||
| // factored out into a function so that the `defer` is scoped to this iterable |
Collaborator
There was a problem hiding this comment.
Good point; but the comment isn't necessary as the code speaks for itself.
Contributor
Author
There was a problem hiding this comment.
The fact that the defer is in the function is obvious but the rationale is probably not so obvious.
Collaborator
There was a problem hiding this comment.
It's fairly common to call a function literal to reduce the scope of a defer.
adonovan
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method update on the type
setis available in the Bazel implementation of Starlark, but unfortunately not this Go implementation. This PR will augment thesetimplementation to also support theupdatemethod.