Docs updates #293
Merged
Docs updates #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportMain: 90.85% | PR: 90.84% | Diff: -0.01 |
Coverage reportMain: 90.85% | PR: 90.84% | Diff: -0.01 |
ianspektor
approved these changes
Oct 30, 2023
achoum
approved these changes
Oct 31, 2023
| @@ -2,7 +2,7 @@ | |||
| # | |||
| files_to_check="docs/src/recipes/*.ipynb" | |||
| files_to_check+=" docs/src/user_guide.ipynb" | |||
| files_to_check+=" docs/src/tutorials/getting_started.ipynb" | |||
There was a problem hiding this comment.
Do we risk breaking existing url that we shared?
Maybe we can add a redirection from tutorials/getting_started.ipynb to getting_started.ipynb?
There was a problem hiding this comment.
Good idea, I'll create a symlink and see if it works.
There was a problem hiding this comment.
FYI: symlink didn't work, but I could configure a redirect through the rtd admin panel.
Coverage reportMain: 90.85% | PR: 90.84% | Diff: -0.01 |
Coverage reportMain: 90.85% | PR: 90.84% | Diff: -0.01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#288 needs to be merged before this (user_guide uses
evset.equal()).Main changes: