Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports in CIFAR-PI baselines #1242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gortizji
Copy link
Contributor

@gortizji gortizji commented Jan 9, 2023

I have spotted a few issues in the new baselines in baselines/privileged_information/cifar_pi:

  1. The local imports in the baselines (e.g., utils.py, ood_utils.py, pi_utils.py) are not recognised when you run as suggested in the README.md.
  2. The new datasets are not listed in uncertainty_baselines/datasets/datasets.py and uncertainty_baselines/datasets/__init__.py.
  3. cifar10n and cifar100n are not allowed options of FLAGS.dataset.
  4. The new augmix flags are not declared anywhere.

Issues 2., 3., and 4. should be fixed by this PR, but the local imports in 1. need to be fixed. This will probably require some restructuring of the baselines directory, either duplicating the utils files inside cifar_pi or working out the relative imports explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant