Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of TODOs blocked on MSRV #67

Open
joshlf opened this issue Oct 15, 2022 · 0 comments
Open

List of TODOs blocked on MSRV #67

joshlf opened this issue Oct 15, 2022 · 0 comments

Comments

@joshlf
Copy link
Member

joshlf commented Oct 15, 2022

This issue is a repository of TODOs which are blocked on updating to a particular MSRV. In addition to those listed here, also see TODO(#67) comments in the source code.

  • In FromZeroes::new_box_slice_zeroed, remove defensive programming which currently works around a bug in Layout::from_size_align
  • Make MaybeValid::as_slice (pending in #279) const once our MSRV is >= 1.64.0, when slice_from_raw_parts was stabilized as const
  • Some instances of #[allow(clippy::as_conversions)] (pending in the current draft of #196) are spurious, and more recent versions of Clippy don't fire in those locations.
  • Some unsafe blocks in macros are marked with #[allow(clippy::undocumented_unsafe_blocks)]; more recent versions of Clippy don't fire in those locations.
  • Once our MSRV is 1.64, we can use this feature to mimic this setting in zerocopy-derive's Cargo.toml in order to cut down on duplication between it and zerocopy's Cargo.toml. This should also allow us to remove some of the CI logic that verifies that metadata in both files matches, since this will be true automatically.
  • Make any functions that use these const: Stabilize const_maybe_uninit_zeroed and const_mem_zeroed rust-lang/rust#116218
  • Use ptr::from_ref and ptr::from_mut
  • Use &mut references in a const context
  • 1.81: Replace #[allow(...)] with #[expect(...)] where appropriate
joshlf added a commit that referenced this issue Oct 12, 2024
Now that our MSRV is 1.65, we can clean up some code.

Makes progress on #67
joshlf added a commit that referenced this issue Oct 12, 2024
Now that our MSRV is 1.65, we can clean up some code.

Makes progress on #67
github-merge-queue bot pushed a commit that referenced this issue Oct 12, 2024
Now that our MSRV is 1.65, we can clean up some code.

Makes progress on #67
github-merge-queue bot pushed a commit that referenced this issue Oct 12, 2024
* Upgrade some code for MSRV 1.65

Now that our MSRV is 1.65, we can clean up some code.

Makes progress on #67

* Upgrade versions of some dependencies

Now that our MSRV is 1.65, it unlocks upgrading some dependencies'
versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant