Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Reference to IFrameElements #88

Closed
dmhalejr opened this issue Jun 24, 2019 · 2 comments
Closed

Local Reference to IFrameElements #88

dmhalejr opened this issue Jun 24, 2019 · 2 comments

Comments

@dmhalejr
Copy link

dmhalejr commented Jun 24, 2019

Hello all,

Trying to figure out how to reference the iframe-elements type gatherer the proper way locally

I also found this GoogleChrome/lighthouse#8979. Should I just await its integration into core lighthouse?

Lighthouse Configuration:

const { report } = await lighthouse(url, {
        port: new URL(browser.wsEndpoint()).port,
        output: "html",
        extends: "lighthouse:full",
        logLevel: "info",
        plugins: ["lighthouse-plugin-publisher-ads"],
        passes: [
          {
            passName: "iframe",
            gatherers: [
              require.resolve(join(__dirname, "../lighthouse-plugin-publisher-ads/gatherers/iframe-elements")),
            ]
          }
        ],
    });

Appropriate Log Level info:

  status Auditing: Structured data is valid +1ms
  status Auditing: No long tasks blocking ad-related network requests +0ms
  status Auditing: Minimal render-blocking resources found +8ms
  status Auditing: Minimal requests found in ad critical path +14ms
  status Auditing: [Experimental] Network is efficiently utilized before ad requests +57ms
  status Auditing: Few or no ads loaded outside viewport +24ms
  Runner:warn IFrameElements gatherer, required by audit ads-in-viewport, did not run. +0ms
  ads-in-viewport:warn Caught exception: Required IFrameElements gatherer did not run. +0ms
  status Auditing: GPT tag is loaded asynchronously +0ms
  status Auditing: GPT tag is loaded over HTTPS +3ms
  status Auditing: GPT tag is loaded from recommended host +3ms
  status Auditing: GPT tag is loaded statically +3ms
  status Auditing: Ad density in initial viewport is within recommended range +3ms
  Runner:warn IFrameElements gatherer, required by audit viewport-ad-density, did not run. +0ms
  viewport-ad-density:warn Caught exception: Required IFrameElements gatherer did not run. +0ms
  status Auditing: Tag load time +0ms
  status Auditing: Latency of first ad request +66ms
  status Auditing: Latency of first ad request, from tag load +51ms
  status Auditing: Latency of first ad render +1ms
  Runner:warn IFrameElements gatherer, required by audit first-ad-paint, did not run. +0ms
  first-ad-paint:warn Caught exception: Required IFrameElements gatherer did not run. +0ms
  status Auditing: Ad slots effectively use horizontal space +0ms
  status Auditing: No ad found at the very top of the viewport +3ms
  Runner:warn IFrameElements gatherer, required by audit ad-top-of-viewport, did not run. +0ms
  ad-top-of-viewport:warn Caught exception: Required IFrameElements gatherer did not run. +0ms
  status Auditing: No duplicate tags found in any frame +0ms
  status Auditing: Header bidding is parallelized +1ms
  status Auditing: No script-injected tags found +4ms
  status Generating results... +4ms
@jburger424
Copy link
Contributor

Hi David,

Apologies for this, we've been meaning to complete this but other items have taken priority.

While you can write a custom config, I think it would probably be best to wait until the iframe gatherer is integrated. I'll aim to complete it by the end of the week.

@dmhalejr
Copy link
Author

@jburger424 No worries! I'll be checking in on GoogleChrome/lighthouse#8979 and close this issue.

Thanks for getting back to me so quickly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants