From a643028b48fd1b3dc2f205e5034990caad56e218 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Fri, 4 Oct 2024 00:11:23 +0000 Subject: [PATCH 01/34] chore: Support Node 18+ * feat: Support Node 18+ * chore: Additional Node 18 upgrades * chore: don't change test fixtures * feat: Move kokoro directories to 18 * chore: Update checkout and setup-node to v4 - https://github.com/actions/checkout/releases/tag/v4.0.0 - https://github.com/actions/setup-node/releases/tag/v4.0.0 Source-Link: https://github.com/googleapis/synthtool/commit/c19dd80df72683437f79151b746c2f22c6bdf8b7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:8060aba1f6d5617d08091767141ab2a99ea1ccbd9371fd42ffc208c5329caa73 --- .github/.OwlBot.lock.yaml | 4 +- .github/CODEOWNERS | 7 +- .github/ISSUE_TEMPLATE/bug_report.yml | 99 +++++++++++++++++++ .../ISSUE_TEMPLATE/documentation_request.yml | 53 ++++++++++ .github/ISSUE_TEMPLATE/feature_request.yml | 53 ++++++++++ .github/ISSUE_TEMPLATE/processs_request.md | 4 + .github/ISSUE_TEMPLATE/questions.md | 8 ++ .github/auto-approve.yml | 4 +- .github/scripts/close-invalid-link.cjs | 56 +++++++++++ .github/scripts/close-unresponsive.cjs | 69 +++++++++++++ .github/scripts/remove-response-label.cjs | 33 +++++++ .github/workflows/ci.yaml | 24 ++--- .github/workflows/issues-no-repro.yaml | 18 ++++ .github/workflows/response.yaml | 35 +++++++ .kokoro/common.cfg | 2 +- .kokoro/continuous/node18/common.cfg | 24 +++++ .kokoro/continuous/node18/lint.cfg | 4 + .kokoro/continuous/node18/samples-test.cfg | 12 +++ .kokoro/continuous/node18/system-test.cfg | 12 +++ .kokoro/continuous/node18/test.cfg | 0 .kokoro/presubmit/node18/common.cfg | 24 +++++ .kokoro/presubmit/node18/samples-test.cfg | 12 +++ .kokoro/presubmit/node18/system-test.cfg | 12 +++ .kokoro/presubmit/node18/test.cfg | 0 .kokoro/release/docs-devsite.cfg | 2 +- .kokoro/release/docs.cfg | 2 +- .kokoro/release/docs.sh | 2 +- .kokoro/release/publish.cfg | 2 +- .kokoro/samples-test.sh | 2 +- .kokoro/system-test.sh | 2 +- .kokoro/test.bat | 2 +- .kokoro/test.sh | 2 +- .kokoro/trampoline_v2.sh | 2 +- 33 files changed, 555 insertions(+), 32 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml create mode 100644 .github/ISSUE_TEMPLATE/documentation_request.yml create mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml create mode 100644 .github/ISSUE_TEMPLATE/processs_request.md create mode 100644 .github/ISSUE_TEMPLATE/questions.md create mode 100644 .github/scripts/close-invalid-link.cjs create mode 100644 .github/scripts/close-unresponsive.cjs create mode 100644 .github/scripts/remove-response-label.cjs create mode 100644 .github/workflows/issues-no-repro.yaml create mode 100644 .github/workflows/response.yaml create mode 100644 .kokoro/continuous/node18/common.cfg create mode 100644 .kokoro/continuous/node18/lint.cfg create mode 100644 .kokoro/continuous/node18/samples-test.cfg create mode 100644 .kokoro/continuous/node18/system-test.cfg create mode 100644 .kokoro/continuous/node18/test.cfg create mode 100644 .kokoro/presubmit/node18/common.cfg create mode 100644 .kokoro/presubmit/node18/samples-test.cfg create mode 100644 .kokoro/presubmit/node18/system-test.cfg create mode 100644 .kokoro/presubmit/node18/test.cfg diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 9e90d54b..972a8c7e 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest - digest: sha256:d920257482ca1cd72978f29f7d28765a9f8c758c21ee0708234db5cf4c5016c2 -# created: 2024-06-12T16:18:41.688792375Z + digest: sha256:8060aba1f6d5617d08091767141ab2a99ea1ccbd9371fd42ffc208c5329caa73 +# created: 2024-10-04T00:09:31.22876583Z diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 80520bba..8b7632f0 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -5,8 +5,5 @@ # https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax -# The yoshi-nodejs team is the default owner for nodejs repositories. -* @googleapis/yoshi-nodejs - -# The github automation team is the default owner for the auto-approve file. -.github/auto-approve.yml @googleapis/github-automation +# Unless specified, the jsteam is the default owner for nodejs repositories. +* @googleapis/jsteam \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 00000000..24b5a410 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,99 @@ +name: Bug Report +description: Create a report to help us improve +labels: + - bug +body: + - type: markdown + attributes: + value: > + **PLEASE READ**: If you have a support contract with Google, please + create an issue in the [support + console](https://cloud.google.com/support/) instead of filing on GitHub. + This will ensure a timely response. Otherwise, please make sure to + follow the steps below. + - type: checkboxes + attributes: + label: Please make sure you have searched for information in the following + guides. + options: + - label: "Search the issues already opened: + https://github.com/GoogleCloudPlatform/google-cloud-node/issues" + required: true + - label: "Search StackOverflow: + http://stackoverflow.com/questions/tagged/google-cloud-platform+nod\ + e.js" + required: true + - label: "Check our Troubleshooting guide: + https://github.com/googleapis/google-cloud-node/blob/main/docs/trou\ + bleshooting.md" + required: true + - label: "Check our FAQ: + https://github.com/googleapis/google-cloud-node/blob/main/docs/faq.\ + md" + required: true + - label: "Check our libraries HOW-TO: + https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ + .md" + required: true + - label: "Check out our authentication guide: + https://github.com/googleapis/google-auth-library-nodejs" + required: true + - label: "Check out handwritten samples for many of our APIs: + https://github.com/GoogleCloudPlatform/nodejs-docs-samples" + required: true + - type: textarea + attributes: + label: > + A screenshot that you have tested with "Try this API". + description: > + As our client libraries are mostly autogenerated, we kindly request + that you test whether your issue is with the client library, or with the + API itself. To do so, please search for your API + here: https://developers.google.com/apis-explorer and attempt to + reproduce the issue in the given method. Please include a screenshot of + the response in "Try this API". This response should NOT match the current + behavior you are experiencing. If the behavior is the same, it means + that you are likely experiencing a bug with the API itself. In that + case, please submit an issue to the API team, either by submitting an + issue in its issue tracker (https://cloud.google.com/support/docs/issue-trackers), or by + submitting an issue in its linked tracker in the .repo-metadata.json + file + validations: + required: true + - type: input + attributes: + label: > + Link to the code that reproduces this issue. A link to a **public** Github Repository or gist with a minimal + reproduction. + description: > + **Skipping this or providing an invalid link will result in the issue being closed** + validations: + required: true + - type: textarea + attributes: + label: > + A step-by-step description of how to reproduce the issue, based on + the linked reproduction. + description: > + Screenshots can be provided in the issue body below. + placeholder: | + 1. Start the application in development (next dev) + 2. Click X + 3. Y will happen + validations: + required: true + - type: textarea + attributes: + label: A clear and concise description of what the bug is, and what you + expected to happen. + placeholder: Following the steps from the previous section, I expected A to + happen, but I observed B instead + validations: + required: true + + - type: textarea + attributes: + label: A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. ** + placeholder: 'Documentation here(link) states that B should happen instead of A' + validations: + required: true diff --git a/.github/ISSUE_TEMPLATE/documentation_request.yml b/.github/ISSUE_TEMPLATE/documentation_request.yml new file mode 100644 index 00000000..2e571c2e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/documentation_request.yml @@ -0,0 +1,53 @@ +name: Documentation Requests +description: Requests for more information +body: + - type: markdown + attributes: + value: > + Please use this issue type to log documentation requests against the library itself. + These requests should involve documentation on Github (`.md` files), and should relate to the library + itself. If you have questions or documentation requests for an API, please + reach out to the API tracker itself. + + Please submit an issue to the API team, either by submitting an + issue in its issue tracker https://cloud.google.com/support/docs/issue-trackers), or by + submitting an issue in its linked tracker in the .repo-metadata.json + file in the API under packages/* ([example]()). + You can also submit a request to documentation on cloud.google.com itself with the "Send Feedback" + on the bottom of the page. + + + Please note that documentation requests and questions for specific APIs + will be closed. + - type: checkboxes + attributes: + label: Please make sure you have searched for information in the following + guides. + options: + - label: "Search the issues already opened: + https://github.com/GoogleCloudPlatform/google-cloud-node/issues" + required: true + - label: "Check our Troubleshooting guide: + https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ + es/troubleshooting" + required: true + - label: "Check our FAQ: + https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ + es/faq" + required: true + - label: "Check our libraries HOW-TO: + https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ + .md" + required: true + - label: "Check out our authentication guide: + https://github.com/googleapis/google-auth-library-nodejs" + required: true + - label: "Check out handwritten samples for many of our APIs: + https://github.com/GoogleCloudPlatform/nodejs-docs-samples" + required: true + - type: textarea + attributes: + label: > + Documentation Request + validations: + required: true diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml new file mode 100644 index 00000000..765444dd --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -0,0 +1,53 @@ +name: Feature Request +description: Suggest an idea for this library +labels: + - feature request +body: + - type: markdown + attributes: + value: > + **PLEASE READ**: If you have a support contract with Google, please + create an issue in the [support + console](https://cloud.google.com/support/) instead of filing on GitHub. + This will ensure a timely response. Otherwise, please make sure to + follow the steps below. + - type: textarea + attributes: + label: > + A screenshot that you have tested with "Try this API". + description: > + As our client libraries are mostly autogenerated, we kindly request + that you test whether your feature request is with the client library, or with the + API itself. To do so, please search for your API + here: https://developers.google.com/apis-explorer and attempt to + reproduce the issue in the given method. Please include a screenshot of + the response in "Try this API". This response should NOT match the current + behavior you are experiencing. If the behavior is the same, it means + that you are likely requesting a feature for the API itself. In that + case, please submit an issue to the API team, either by submitting an + issue in its issue tracker https://cloud.google.com/support/docs/issue-trackers, or by + submitting an issue in its linked tracker in the .repo-metadata.json + file in the API under packages/* ([example]()) + + Example of library specific issues would be: retry strategies, authentication questions, or issues with typings. + Examples of API issues would include: expanding method parameter types, adding functionality to an API. + validations: + required: true + - type: textarea + attributes: + label: > + What would you like to see in the library? + description: > + Screenshots can be provided in the issue body below. + placeholder: | + 1. Set up authentication like so + 2. Run the program like so + 3. X would be nice to happen + + - type: textarea + attributes: + label: Describe alternatives you've considered + + - type: textarea + attributes: + label: Additional context/notes \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md new file mode 100644 index 00000000..45682e8f --- /dev/null +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -0,0 +1,4 @@ +--- +name: Process Request +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, for example CI/CD, publishing, releasing, broken links. +--- diff --git a/.github/ISSUE_TEMPLATE/questions.md b/.github/ISSUE_TEMPLATE/questions.md new file mode 100644 index 00000000..62c1dd1b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/questions.md @@ -0,0 +1,8 @@ +--- +name: Question +about: If you have a question, please use Discussions + +--- + +If you have a general question that goes beyond the library itself, we encourage you to use [Discussions](https://github.com//discussions) +to engage with fellow community members! diff --git a/.github/auto-approve.yml b/.github/auto-approve.yml index ec51b072..7cba0af6 100644 --- a/.github/auto-approve.yml +++ b/.github/auto-approve.yml @@ -1,4 +1,2 @@ processes: - - "NodeDependency" - - "OwlBotTemplateChangesNode" - - "OwlBotPRsNode" \ No newline at end of file + - "NodeDependency" \ No newline at end of file diff --git a/.github/scripts/close-invalid-link.cjs b/.github/scripts/close-invalid-link.cjs new file mode 100644 index 00000000..d7a3688e --- /dev/null +++ b/.github/scripts/close-invalid-link.cjs @@ -0,0 +1,56 @@ +// Copyright 2024 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +async function closeIssue(github, owner, repo, number) { + await github.rest.issues.createComment({ + owner: owner, + repo: repo, + issue_number: number, + body: 'Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)' + }); + await github.rest.issues.update({ + owner: owner, + repo: repo, + issue_number: number, + state: 'closed' + }); +} +module.exports = async ({github, context}) => { + const owner = context.repo.owner; + const repo = context.repo.repo; + const number = context.issue.number; + + const issue = await github.rest.issues.get({ + owner: owner, + repo: repo, + issue_number: number, + }); + + const isBugTemplate = issue.data.body.includes('Link to the code that reproduces this issue'); + + if (isBugTemplate) { + console.log(`Issue ${number} is a bug template`) + try { + const link = issue.data.body.split('\n')[18].match(/(https?:\/\/(gist\.)?github.com\/.*)/)[0]; + console.log(`Issue ${number} contains this link: ${link}`) + const isValidLink = (await fetch(link)).ok; + console.log(`Issue ${number} has a ${isValidLink ? 'valid' : 'invalid'} link`) + if (!isValidLink) { + await closeIssue(github, owner, repo, number); + } + } catch (err) { + await closeIssue(github, owner, repo, number); + } + } +}; diff --git a/.github/scripts/close-unresponsive.cjs b/.github/scripts/close-unresponsive.cjs new file mode 100644 index 00000000..142dc126 --- /dev/null +++ b/.github/scripts/close-unresponsive.cjs @@ -0,0 +1,69 @@ +// Copyright 2024 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +function labeledEvent(data) { + return data.event === 'labeled' && data.label.name === 'needs more info'; + } + + const numberOfDaysLimit = 15; + const close_message = `This has been closed since a request for information has \ + not been answered for ${numberOfDaysLimit} days. It can be reopened when the \ + requested information is provided.`; + + module.exports = async ({github, context}) => { + const owner = context.repo.owner; + const repo = context.repo.repo; + + const issues = await github.rest.issues.listForRepo({ + owner: owner, + repo: repo, + labels: 'needs more info', + }); + const numbers = issues.data.map((e) => e.number); + + for (const number of numbers) { + const events = await github.paginate( + github.rest.issues.listEventsForTimeline, + { + owner: owner, + repo: repo, + issue_number: number, + }, + (response) => response.data.filter(labeledEvent) + ); + + const latest_response_label = events[events.length - 1]; + + const created_at = new Date(latest_response_label.created_at); + const now = new Date(); + const diff = now - created_at; + const diffDays = diff / (1000 * 60 * 60 * 24); + + if (diffDays > numberOfDaysLimit) { + await github.rest.issues.update({ + owner: owner, + repo: repo, + issue_number: number, + state: 'closed', + }); + + await github.rest.issues.createComment({ + owner: owner, + repo: repo, + issue_number: number, + body: close_message, + }); + } + } + }; diff --git a/.github/scripts/remove-response-label.cjs b/.github/scripts/remove-response-label.cjs new file mode 100644 index 00000000..887cf349 --- /dev/null +++ b/.github/scripts/remove-response-label.cjs @@ -0,0 +1,33 @@ +// Copyright 2024 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +module.exports = async ({ github, context }) => { + const commenter = context.actor; + const issue = await github.rest.issues.get({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + }); + const author = issue.data.user.login; + const labels = issue.data.labels.map((e) => e.name); + + if (author === commenter && labels.includes('needs more info')) { + await github.rest.issues.removeLabel({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + name: 'needs more info', + }); + } + }; diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 4892eb2c..9901e14c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,10 +9,10 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [14, 16, 18, 20] + node: [14, 16, 18}] steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - run: node --version @@ -29,10 +29,10 @@ jobs: windows: runs-on: windows-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 14 + node-version: 18 - run: npm install --engine-strict - run: npm test env: @@ -40,19 +40,19 @@ jobs: lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 14 + node-version: 18 - run: npm install - run: npm run lint docs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 14 + node-version: 18 - run: npm install - run: npm run docs - uses: JustinBeckwith/linkinator-action@v1 diff --git a/.github/workflows/issues-no-repro.yaml b/.github/workflows/issues-no-repro.yaml new file mode 100644 index 00000000..442a46bc --- /dev/null +++ b/.github/workflows/issues-no-repro.yaml @@ -0,0 +1,18 @@ +name: invalid_link +on: + issues: + types: [opened, reopened] + +jobs: + close: + runs-on: ubuntu-latest + permissions: + issues: write + pull-requests: write + steps: + - uses: actions/checkout@v4 + - uses: actions/github-script@v7 + with: + script: | + const script = require('./.github/scripts/close-invalid-link.cjs') + await script({github, context}) diff --git a/.github/workflows/response.yaml b/.github/workflows/response.yaml new file mode 100644 index 00000000..6ed37326 --- /dev/null +++ b/.github/workflows/response.yaml @@ -0,0 +1,35 @@ +name: no_response +on: + schedule: + - cron: '30 1 * * *' # Run every day at 01:30 + workflow_dispatch: + issue_comment: + +jobs: + close: + if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' + runs-on: ubuntu-latest + permissions: + issues: write + pull-requests: write + steps: + - uses: actions/checkout@v4 + - uses: actions/github-script@v7 + with: + script: | + const script = require('./.github/scripts/close-unresponsive.cjs') + await script({github, context}) + + remove_label: + if: github.event_name == 'issue_comment' + runs-on: ubuntu-latest + permissions: + issues: write + pull-requests: write + steps: + - uses: actions/checkout@v4 + - uses: actions/github-script@v7 + with: + script: | + const script = require('./.github/scripts/remove-response-label.cjs') + await script({github, context}) diff --git a/.kokoro/common.cfg b/.kokoro/common.cfg index 5be3d47c..f3d02615 100644 --- a/.kokoro/common.cfg +++ b/.kokoro/common.cfg @@ -16,7 +16,7 @@ build_file: "gaxios/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" } env_vars: { key: "TRAMPOLINE_BUILD_FILE" diff --git a/.kokoro/continuous/node18/common.cfg b/.kokoro/continuous/node18/common.cfg new file mode 100644 index 00000000..f3d02615 --- /dev/null +++ b/.kokoro/continuous/node18/common.cfg @@ -0,0 +1,24 @@ +# Format: //devtools/kokoro/config/proto/build.proto + +# Build logs will be here +action { + define_artifacts { + regex: "**/*sponge_log.xml" + } +} + +# Download trampoline resources. +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline" + +# Use the trampoline script to run in docker. +build_file: "gaxios/.kokoro/trampoline_v2.sh" + +# Configure the docker image for kokoro-trampoline. +env_vars: { + key: "TRAMPOLINE_IMAGE" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" +} +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/gaxios/.kokoro/test.sh" +} diff --git a/.kokoro/continuous/node18/lint.cfg b/.kokoro/continuous/node18/lint.cfg new file mode 100644 index 00000000..16e4d2d2 --- /dev/null +++ b/.kokoro/continuous/node18/lint.cfg @@ -0,0 +1,4 @@ +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/gaxios/.kokoro/lint.sh" +} diff --git a/.kokoro/continuous/node18/samples-test.cfg b/.kokoro/continuous/node18/samples-test.cfg new file mode 100644 index 00000000..8adc8fae --- /dev/null +++ b/.kokoro/continuous/node18/samples-test.cfg @@ -0,0 +1,12 @@ +# Download resources for system tests (service account key, etc.) +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" + +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/gaxios/.kokoro/samples-test.sh" +} + +env_vars: { + key: "SECRET_MANAGER_KEYS" + value: "long-door-651-kokoro-system-test-service-account" +} \ No newline at end of file diff --git a/.kokoro/continuous/node18/system-test.cfg b/.kokoro/continuous/node18/system-test.cfg new file mode 100644 index 00000000..0f2d493c --- /dev/null +++ b/.kokoro/continuous/node18/system-test.cfg @@ -0,0 +1,12 @@ +# Download resources for system tests (service account key, etc.) +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" + +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/gaxios/.kokoro/system-test.sh" +} + +env_vars: { + key: "SECRET_MANAGER_KEYS" + value: "long-door-651-kokoro-system-test-service-account" +} \ No newline at end of file diff --git a/.kokoro/continuous/node18/test.cfg b/.kokoro/continuous/node18/test.cfg new file mode 100644 index 00000000..e69de29b diff --git a/.kokoro/presubmit/node18/common.cfg b/.kokoro/presubmit/node18/common.cfg new file mode 100644 index 00000000..f3d02615 --- /dev/null +++ b/.kokoro/presubmit/node18/common.cfg @@ -0,0 +1,24 @@ +# Format: //devtools/kokoro/config/proto/build.proto + +# Build logs will be here +action { + define_artifacts { + regex: "**/*sponge_log.xml" + } +} + +# Download trampoline resources. +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline" + +# Use the trampoline script to run in docker. +build_file: "gaxios/.kokoro/trampoline_v2.sh" + +# Configure the docker image for kokoro-trampoline. +env_vars: { + key: "TRAMPOLINE_IMAGE" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" +} +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/gaxios/.kokoro/test.sh" +} diff --git a/.kokoro/presubmit/node18/samples-test.cfg b/.kokoro/presubmit/node18/samples-test.cfg new file mode 100644 index 00000000..8adc8fae --- /dev/null +++ b/.kokoro/presubmit/node18/samples-test.cfg @@ -0,0 +1,12 @@ +# Download resources for system tests (service account key, etc.) +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" + +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/gaxios/.kokoro/samples-test.sh" +} + +env_vars: { + key: "SECRET_MANAGER_KEYS" + value: "long-door-651-kokoro-system-test-service-account" +} \ No newline at end of file diff --git a/.kokoro/presubmit/node18/system-test.cfg b/.kokoro/presubmit/node18/system-test.cfg new file mode 100644 index 00000000..0f2d493c --- /dev/null +++ b/.kokoro/presubmit/node18/system-test.cfg @@ -0,0 +1,12 @@ +# Download resources for system tests (service account key, etc.) +gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" + +env_vars: { + key: "TRAMPOLINE_BUILD_FILE" + value: "github/gaxios/.kokoro/system-test.sh" +} + +env_vars: { + key: "SECRET_MANAGER_KEYS" + value: "long-door-651-kokoro-system-test-service-account" +} \ No newline at end of file diff --git a/.kokoro/presubmit/node18/test.cfg b/.kokoro/presubmit/node18/test.cfg new file mode 100644 index 00000000..e69de29b diff --git a/.kokoro/release/docs-devsite.cfg b/.kokoro/release/docs-devsite.cfg index 7e8ddaaf..a5793104 100644 --- a/.kokoro/release/docs-devsite.cfg +++ b/.kokoro/release/docs-devsite.cfg @@ -11,7 +11,7 @@ before_action { # doc publications use a Python image. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" } # Download trampoline resources. diff --git a/.kokoro/release/docs.cfg b/.kokoro/release/docs.cfg index c132e0e7..434d1f77 100644 --- a/.kokoro/release/docs.cfg +++ b/.kokoro/release/docs.cfg @@ -11,7 +11,7 @@ before_action { # doc publications use a Python image. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" } # Download trampoline resources. diff --git a/.kokoro/release/docs.sh b/.kokoro/release/docs.sh index 1d8f3f49..e9079a60 100755 --- a/.kokoro/release/docs.sh +++ b/.kokoro/release/docs.sh @@ -16,7 +16,7 @@ set -eo pipefail -# build jsdocs (Python is installed on the Node 10 docker image). +# build jsdocs (Python is installed on the Node 18 docker image). if [[ -z "$CREDENTIALS" ]]; then # if CREDENTIALS are explicitly set, assume we're testing locally # and don't set NPM_CONFIG_PREFIX. diff --git a/.kokoro/release/publish.cfg b/.kokoro/release/publish.cfg index 19898330..7e6da42b 100644 --- a/.kokoro/release/publish.cfg +++ b/.kokoro/release/publish.cfg @@ -30,7 +30,7 @@ build_file: "gaxios/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" } env_vars: { diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 8c5d108c..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -56,7 +56,7 @@ fi # codecov combines coverage across integration and unit tests. Include # the logic below for any environment you wish to collect coverage for: -COVERAGE_NODE=14 +COVERAGE_NODE=18 if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then NYC_BIN=./node_modules/nyc/bin/nyc.js if [ -f "$NYC_BIN" ]; then diff --git a/.kokoro/system-test.sh b/.kokoro/system-test.sh index 0b3043d2..a90d5cfe 100755 --- a/.kokoro/system-test.sh +++ b/.kokoro/system-test.sh @@ -49,7 +49,7 @@ npm run system-test # codecov combines coverage across integration and unit tests. Include # the logic below for any environment you wish to collect coverage for: -COVERAGE_NODE=14 +COVERAGE_NODE=18 if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then NYC_BIN=./node_modules/nyc/bin/nyc.js if [ -f "$NYC_BIN" ]; then diff --git a/.kokoro/test.bat b/.kokoro/test.bat index 0bb12405..caf82565 100644 --- a/.kokoro/test.bat +++ b/.kokoro/test.bat @@ -21,7 +21,7 @@ cd .. @rem we upgrade Node.js in the image: SET PATH=%PATH%;/cygdrive/c/Program Files/nodejs/npm -call nvm use v14.17.3 +call nvm use 18 call which node call npm install || goto :error diff --git a/.kokoro/test.sh b/.kokoro/test.sh index 862d478d..0d9f6392 100755 --- a/.kokoro/test.sh +++ b/.kokoro/test.sh @@ -39,7 +39,7 @@ npm test # codecov combines coverage across integration and unit tests. Include # the logic below for any environment you wish to collect coverage for: -COVERAGE_NODE=14 +COVERAGE_NODE=18 if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then NYC_BIN=./node_modules/nyc/bin/nyc.js if [ -f "$NYC_BIN" ]; then diff --git a/.kokoro/trampoline_v2.sh b/.kokoro/trampoline_v2.sh index 4d031121..5d6cfcca 100755 --- a/.kokoro/trampoline_v2.sh +++ b/.kokoro/trampoline_v2.sh @@ -44,7 +44,7 @@ # the project root. # # Here is an example for running this script. -# TRAMPOLINE_IMAGE=gcr.io/cloud-devrel-kokoro-resources/node:10-user \ +# TRAMPOLINE_IMAGE=gcr.io/cloud-devrel-kokoro-resources/node:18-user \ # TRAMPOLINE_BUILD_FILE=.kokoro/system-test.sh \ # .kokoro/trampoline_v2.sh From 3fc97b8d2d6cbdf8be8ec98fbd076e4ac58ccdd4 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Tue, 15 Oct 2024 11:39:09 -0700 Subject: [PATCH 02/34] chore: Update .OwlBot.lock.yaml --- .github/.OwlBot.lock.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 972a8c7e..bda9384d 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest - digest: sha256:8060aba1f6d5617d08091767141ab2a99ea1ccbd9371fd42ffc208c5329caa73 + digest: sha256:bd8b41503cfcbd21f121e4b197d0f8bf1447f3499921f18441bb7e6e3ae8f7fa # created: 2024-10-04T00:09:31.22876583Z From c092e76611ef3c8ca7acf0f291e07b41e702e9a4 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 15 Oct 2024 18:41:25 +0000 Subject: [PATCH 03/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 9901e14c..e2075983 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [14, 16, 18}] + node: [14, 16, 18] steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 From 2b3209889bf5b4fd975a3df270fb5662d4399c77 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Tue, 15 Oct 2024 11:47:26 -0700 Subject: [PATCH 04/34] chore: bump to Node 18 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d02b32d7..487c6c1a 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "google" ], "engines": { - "node": ">=14" + "node": ">=18" }, "author": "Google, LLC", "license": "Apache-2.0", From 836e05d1c0ef17569964fbfb0837552e13839ba8 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Tue, 15 Oct 2024 11:51:10 -0700 Subject: [PATCH 05/34] chore: bump to Node v18 --- .github/sync-repo-settings.yaml | 4 ++-- .github/workflows/ci.yaml | 2 +- .kokoro/continuous/node14/common.cfg | 2 +- .kokoro/presubmit/node14/common.cfg | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml index b46e4c4d..a013376d 100644 --- a/.github/sync-repo-settings.yaml +++ b/.github/sync-repo-settings.yaml @@ -8,9 +8,9 @@ branchProtectionRules: - "ci/kokoro: Samples test" - "ci/kokoro: System test" - lint - - test (14) - - test (16) - test (18) + - test (20) + - test (22) - cla/google - windows - OwlBot Post Processor diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e2075983..791891a0 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [14, 16, 18] + node: [18, 20, 22] steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 diff --git a/.kokoro/continuous/node14/common.cfg b/.kokoro/continuous/node14/common.cfg index 5be3d47c..f3d02615 100644 --- a/.kokoro/continuous/node14/common.cfg +++ b/.kokoro/continuous/node14/common.cfg @@ -16,7 +16,7 @@ build_file: "gaxios/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" } env_vars: { key: "TRAMPOLINE_BUILD_FILE" diff --git a/.kokoro/presubmit/node14/common.cfg b/.kokoro/presubmit/node14/common.cfg index 5be3d47c..f3d02615 100644 --- a/.kokoro/presubmit/node14/common.cfg +++ b/.kokoro/presubmit/node14/common.cfg @@ -16,7 +16,7 @@ build_file: "gaxios/.kokoro/trampoline_v2.sh" # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user" + value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" } env_vars: { key: "TRAMPOLINE_BUILD_FILE" From bba133db1fbeb8aa09a5e60cb9b52e6523de039f Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Tue, 15 Oct 2024 12:13:21 -0700 Subject: [PATCH 06/34] chore: remove Node 14 references --- .kokoro/continuous/node14/common.cfg | 24 ---------------------- .kokoro/continuous/node14/lint.cfg | 4 ---- .kokoro/continuous/node14/samples-test.cfg | 12 ----------- .kokoro/continuous/node14/system-test.cfg | 12 ----------- .kokoro/continuous/node14/test.cfg | 0 .kokoro/presubmit/node14/common.cfg | 24 ---------------------- .kokoro/presubmit/node14/samples-test.cfg | 12 ----------- .kokoro/presubmit/node14/system-test.cfg | 12 ----------- .kokoro/presubmit/node14/test.cfg | 0 9 files changed, 100 deletions(-) delete mode 100644 .kokoro/continuous/node14/common.cfg delete mode 100644 .kokoro/continuous/node14/lint.cfg delete mode 100644 .kokoro/continuous/node14/samples-test.cfg delete mode 100644 .kokoro/continuous/node14/system-test.cfg delete mode 100644 .kokoro/continuous/node14/test.cfg delete mode 100644 .kokoro/presubmit/node14/common.cfg delete mode 100644 .kokoro/presubmit/node14/samples-test.cfg delete mode 100644 .kokoro/presubmit/node14/system-test.cfg delete mode 100644 .kokoro/presubmit/node14/test.cfg diff --git a/.kokoro/continuous/node14/common.cfg b/.kokoro/continuous/node14/common.cfg deleted file mode 100644 index f3d02615..00000000 --- a/.kokoro/continuous/node14/common.cfg +++ /dev/null @@ -1,24 +0,0 @@ -# Format: //devtools/kokoro/config/proto/build.proto - -# Build logs will be here -action { - define_artifacts { - regex: "**/*sponge_log.xml" - } -} - -# Download trampoline resources. -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline" - -# Use the trampoline script to run in docker. -build_file: "gaxios/.kokoro/trampoline_v2.sh" - -# Configure the docker image for kokoro-trampoline. -env_vars: { - key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" -} -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/gaxios/.kokoro/test.sh" -} diff --git a/.kokoro/continuous/node14/lint.cfg b/.kokoro/continuous/node14/lint.cfg deleted file mode 100644 index 16e4d2d2..00000000 --- a/.kokoro/continuous/node14/lint.cfg +++ /dev/null @@ -1,4 +0,0 @@ -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/gaxios/.kokoro/lint.sh" -} diff --git a/.kokoro/continuous/node14/samples-test.cfg b/.kokoro/continuous/node14/samples-test.cfg deleted file mode 100644 index 8adc8fae..00000000 --- a/.kokoro/continuous/node14/samples-test.cfg +++ /dev/null @@ -1,12 +0,0 @@ -# Download resources for system tests (service account key, etc.) -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" - -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/gaxios/.kokoro/samples-test.sh" -} - -env_vars: { - key: "SECRET_MANAGER_KEYS" - value: "long-door-651-kokoro-system-test-service-account" -} \ No newline at end of file diff --git a/.kokoro/continuous/node14/system-test.cfg b/.kokoro/continuous/node14/system-test.cfg deleted file mode 100644 index 0f2d493c..00000000 --- a/.kokoro/continuous/node14/system-test.cfg +++ /dev/null @@ -1,12 +0,0 @@ -# Download resources for system tests (service account key, etc.) -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" - -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/gaxios/.kokoro/system-test.sh" -} - -env_vars: { - key: "SECRET_MANAGER_KEYS" - value: "long-door-651-kokoro-system-test-service-account" -} \ No newline at end of file diff --git a/.kokoro/continuous/node14/test.cfg b/.kokoro/continuous/node14/test.cfg deleted file mode 100644 index e69de29b..00000000 diff --git a/.kokoro/presubmit/node14/common.cfg b/.kokoro/presubmit/node14/common.cfg deleted file mode 100644 index f3d02615..00000000 --- a/.kokoro/presubmit/node14/common.cfg +++ /dev/null @@ -1,24 +0,0 @@ -# Format: //devtools/kokoro/config/proto/build.proto - -# Build logs will be here -action { - define_artifacts { - regex: "**/*sponge_log.xml" - } -} - -# Download trampoline resources. -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline" - -# Use the trampoline script to run in docker. -build_file: "gaxios/.kokoro/trampoline_v2.sh" - -# Configure the docker image for kokoro-trampoline. -env_vars: { - key: "TRAMPOLINE_IMAGE" - value: "gcr.io/cloud-devrel-kokoro-resources/node:18-user" -} -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/gaxios/.kokoro/test.sh" -} diff --git a/.kokoro/presubmit/node14/samples-test.cfg b/.kokoro/presubmit/node14/samples-test.cfg deleted file mode 100644 index 8adc8fae..00000000 --- a/.kokoro/presubmit/node14/samples-test.cfg +++ /dev/null @@ -1,12 +0,0 @@ -# Download resources for system tests (service account key, etc.) -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" - -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/gaxios/.kokoro/samples-test.sh" -} - -env_vars: { - key: "SECRET_MANAGER_KEYS" - value: "long-door-651-kokoro-system-test-service-account" -} \ No newline at end of file diff --git a/.kokoro/presubmit/node14/system-test.cfg b/.kokoro/presubmit/node14/system-test.cfg deleted file mode 100644 index 0f2d493c..00000000 --- a/.kokoro/presubmit/node14/system-test.cfg +++ /dev/null @@ -1,12 +0,0 @@ -# Download resources for system tests (service account key, etc.) -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" - -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/gaxios/.kokoro/system-test.sh" -} - -env_vars: { - key: "SECRET_MANAGER_KEYS" - value: "long-door-651-kokoro-system-test-service-account" -} \ No newline at end of file diff --git a/.kokoro/presubmit/node14/test.cfg b/.kokoro/presubmit/node14/test.cfg deleted file mode 100644 index e69de29b..00000000 From 57b4d83756c5ee9e021603cf0802e81b5b2f184f Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 16 Oct 2024 14:30:22 -0700 Subject: [PATCH 07/34] chore: temp remove `NPM_CONFIG_PREFIX` from samples-test --- .kokoro/samples-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..7ece1447 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,7 +16,7 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global +# export NPM_CONFIG_PREFIX=${HOME}/.npm-global # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From 74c2377a56ca167b479ccfaeef3952aaccad9d40 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 16 Oct 2024 21:32:50 +0000 Subject: [PATCH 08/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 7ece1447..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,7 +16,7 @@ set -eo pipefail -# export NPM_CONFIG_PREFIX=${HOME}/.npm-global +export NPM_CONFIG_PREFIX=${HOME}/.npm-global # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From fb83ead395477236b84b332aa311dfb151f1e3a8 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 16 Oct 2024 14:45:57 -0700 Subject: [PATCH 09/34] chore: create `NPM_CONFIG_PREFIX` if it doesn't exist --- .kokoro/samples-test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..75accfdf 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -17,6 +17,7 @@ set -eo pipefail export NPM_CONFIG_PREFIX=${HOME}/.npm-global +touch "$NPM_CONFIG_PREFIX" # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From eef8aafe4af7dee3dc82095fca6eb99a4b88374d Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 16 Oct 2024 21:48:21 +0000 Subject: [PATCH 10/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 75accfdf..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -17,7 +17,6 @@ set -eo pipefail export NPM_CONFIG_PREFIX=${HOME}/.npm-global -touch "$NPM_CONFIG_PREFIX" # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From b0c10519c36996c1e92e3b87a49b1ddc58e777a2 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 16 Oct 2024 15:01:48 -0700 Subject: [PATCH 11/34] chore: mkdir -p if `NPM_CONFIG_PREFIX` does not exist --- .kokoro/samples-test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..d0c9a7ba 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -17,6 +17,7 @@ set -eo pipefail export NPM_CONFIG_PREFIX=${HOME}/.npm-global +mkdir -p "$NPM_CONFIG_PREFIX" # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From 59e3a606ac8a9ae7ba06b369fb8eca9ed573e801 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Thu, 17 Oct 2024 10:59:23 -0700 Subject: [PATCH 12/34] chore: install `npm@10` --- .kokoro/samples-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index d0c9a7ba..165db6ca 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -17,7 +17,7 @@ set -eo pipefail export NPM_CONFIG_PREFIX=${HOME}/.npm-global -mkdir -p "$NPM_CONFIG_PREFIX" +npm install -g npm@10 # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From 9477f68af5979c7c1509dad2b1bdc36f56f94dca Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Mon, 21 Oct 2024 10:46:37 -0700 Subject: [PATCH 13/34] chore: verify npm `10.7` --- .kokoro/samples-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 165db6ca..27e51db8 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -17,7 +17,7 @@ set -eo pipefail export NPM_CONFIG_PREFIX=${HOME}/.npm-global -npm install -g npm@10 +npm install -g npm@10.7 # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From 8a41bb5b1b49a51117c5f3da48f92cfb4e0567e8 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Mon, 21 Oct 2024 17:49:02 +0000 Subject: [PATCH 14/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 27e51db8..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -17,7 +17,6 @@ set -eo pipefail export NPM_CONFIG_PREFIX=${HOME}/.npm-global -npm install -g npm@10.7 # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From f798e17736bde2729335a978883c61d00e4cb4f5 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 23 Oct 2024 11:39:36 -0700 Subject: [PATCH 15/34] chore: npm debugging --- .kokoro/samples-test.sh | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..b513aefa 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,8 +16,24 @@ set -eo pipefail +echo "NPM_CONFIG_PREFIX BEFORE: $NPM_CONFIG_PREFIX" + export NPM_CONFIG_PREFIX=${HOME}/.npm-global +echo "===PRE: NPM DEBUGGING===" +which npm +whereis npm + +echo "===INSTALL: NPM DEBUGGING===" +npm install npm@10 + +echo "===POST: NPM DEBUGGING===" +which npm +whereis npm + +echo "===RUN: NPM DEBUGGING===" + + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -34,10 +50,18 @@ fi if [ -f samples/package.json ]; then npm install + echo "===1: NPM DEBUGGING===" + # Install and link samples cd samples/ + + echo "===2: NPM DEBUGGING===" npm link ../ + + echo "===3: NPM DEBUGGING===" npm install + + echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -51,7 +75,10 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi + + echo "===5: NPM DEBUGGING===" npm run samples-test + echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -62,7 +89,12 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi + + echo "===7: NPM DEBUGGING===" + bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi + +echo "===DONE: NPM DEBUGGING===" From d55d655817f9caa047e18264b36699c71d577cf5 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 23 Oct 2024 18:41:44 +0000 Subject: [PATCH 16/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index b513aefa..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,24 +16,8 @@ set -eo pipefail -echo "NPM_CONFIG_PREFIX BEFORE: $NPM_CONFIG_PREFIX" - export NPM_CONFIG_PREFIX=${HOME}/.npm-global -echo "===PRE: NPM DEBUGGING===" -which npm -whereis npm - -echo "===INSTALL: NPM DEBUGGING===" -npm install npm@10 - -echo "===POST: NPM DEBUGGING===" -which npm -whereis npm - -echo "===RUN: NPM DEBUGGING===" - - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -50,18 +34,10 @@ fi if [ -f samples/package.json ]; then npm install - echo "===1: NPM DEBUGGING===" - # Install and link samples cd samples/ - - echo "===2: NPM DEBUGGING===" npm link ../ - - echo "===3: NPM DEBUGGING===" npm install - - echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -75,10 +51,7 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi - - echo "===5: NPM DEBUGGING===" npm run samples-test - echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -89,12 +62,7 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi - - echo "===7: NPM DEBUGGING===" - bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi - -echo "===DONE: NPM DEBUGGING===" From 12cc60d90604290aef6dccf7f2dd09528d3beb2a Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 23 Oct 2024 11:46:35 -0700 Subject: [PATCH 17/34] chore: more npm debugging --- .kokoro/samples-test.sh | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..d0215ba8 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,8 +16,26 @@ set -eo pipefail +echo "NPM_CONFIG_PREFIX BEFORE: $NPM_CONFIG_PREFIX" + export NPM_CONFIG_PREFIX=${HOME}/.npm-global +echo "===PRE: NPM DEBUGGING===" +which npm +whereis npm +npm -v + +echo "===INSTALL: NPM DEBUGGING===" +npm install -g npm@10 + +echo "===POST: NPM DEBUGGING===" +which npm +whereis npm +npm -v + +echo "===RUN: NPM DEBUGGING===" + + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -32,12 +50,19 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then + echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ + + echo "===2: NPM DEBUGGING===" npm link ../ + + echo "===3: NPM DEBUGGING===" npm install + + echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -51,7 +76,10 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi + + echo "===5: NPM DEBUGGING===" npm run samples-test + echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -62,7 +90,12 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi + + echo "===7: NPM DEBUGGING===" + bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi + +echo "===DONE: NPM DEBUGGING===" From a857cde4444fa9d00bd8f87edb2297997f32c9ad Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 23 Oct 2024 18:48:46 +0000 Subject: [PATCH 18/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index d0215ba8..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,26 +16,8 @@ set -eo pipefail -echo "NPM_CONFIG_PREFIX BEFORE: $NPM_CONFIG_PREFIX" - export NPM_CONFIG_PREFIX=${HOME}/.npm-global -echo "===PRE: NPM DEBUGGING===" -which npm -whereis npm -npm -v - -echo "===INSTALL: NPM DEBUGGING===" -npm install -g npm@10 - -echo "===POST: NPM DEBUGGING===" -which npm -whereis npm -npm -v - -echo "===RUN: NPM DEBUGGING===" - - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -50,19 +32,12 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then - echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ - - echo "===2: NPM DEBUGGING===" npm link ../ - - echo "===3: NPM DEBUGGING===" npm install - - echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -76,10 +51,7 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi - - echo "===5: NPM DEBUGGING===" npm run samples-test - echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -90,12 +62,7 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi - - echo "===7: NPM DEBUGGING===" - bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi - -echo "===DONE: NPM DEBUGGING===" From 1a49faeeebf957b95356eb1e45c407d02b8f405e Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 23 Oct 2024 11:58:20 -0700 Subject: [PATCH 19/34] chore: npm debugging --- .kokoro/samples-test.sh | 43 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..d79a3a9b 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,8 +16,36 @@ set -eo pipefail +echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" +echo "$NPM_CONFIG_PREFIX" + +( + unset -e + echo "===UPDATE NOTIFIER: NPM DEBUGGING===" + echo npm config get update-notifier + echo npm config set update-notifier false +) + export NPM_CONFIG_PREFIX=${HOME}/.npm-global +echo "===PRE: NPM DEBUGGING===" +which npm +whereis npm +npm -v +echo npm config get update-notifier + +echo "===INSTALL: NPM DEBUGGING===" +npm install -g npm@10 + +echo "===POST: NPM DEBUGGING===" +which npm +whereis npm +npm -v +echo npm config get update-notifier + +echo "===RUN: NPM DEBUGGING===" + + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -32,12 +60,19 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then + echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ + + echo "===2: NPM DEBUGGING===" npm link ../ + + echo "===3: NPM DEBUGGING===" npm install + + echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -51,7 +86,10 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi + echo "===5: NPM DEBUGGING===" npm run samples-test + + echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -62,7 +100,12 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi + + echo "===7: NPM DEBUGGING===" + bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi + +echo "===DONE: NPM DEBUGGING===" From 59d00d8f52424a46c034d6fe3caac72a7c42bbd5 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 23 Oct 2024 19:00:31 +0000 Subject: [PATCH 20/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 43 ----------------------------------------- 1 file changed, 43 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index d79a3a9b..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,36 +16,8 @@ set -eo pipefail -echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" -echo "$NPM_CONFIG_PREFIX" - -( - unset -e - echo "===UPDATE NOTIFIER: NPM DEBUGGING===" - echo npm config get update-notifier - echo npm config set update-notifier false -) - export NPM_CONFIG_PREFIX=${HOME}/.npm-global -echo "===PRE: NPM DEBUGGING===" -which npm -whereis npm -npm -v -echo npm config get update-notifier - -echo "===INSTALL: NPM DEBUGGING===" -npm install -g npm@10 - -echo "===POST: NPM DEBUGGING===" -which npm -whereis npm -npm -v -echo npm config get update-notifier - -echo "===RUN: NPM DEBUGGING===" - - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -60,19 +32,12 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then - echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ - - echo "===2: NPM DEBUGGING===" npm link ../ - - echo "===3: NPM DEBUGGING===" npm install - - echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -86,10 +51,7 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi - echo "===5: NPM DEBUGGING===" npm run samples-test - - echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -100,12 +62,7 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi - - echo "===7: NPM DEBUGGING===" - bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi - -echo "===DONE: NPM DEBUGGING===" From 02c8ab81fa6d12d5efe5a04aab7709895f2374c2 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 23 Oct 2024 12:04:28 -0700 Subject: [PATCH 21/34] chore: npm debugging --- .kokoro/samples-test.sh | 42 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..2d1aaf91 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,8 +16,35 @@ set -eo pipefail +echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" +echo "$NPM_CONFIG_PREFIX" + +( + echo "===UPDATE NOTIFIER: NPM DEBUGGING===" + echo npm config get update-notifier + echo npm config set update-notifier false +) + export NPM_CONFIG_PREFIX=${HOME}/.npm-global +echo "===PRE: NPM DEBUGGING===" +which npm +whereis npm +npm -v +echo npm config get update-notifier + +echo "===INSTALL: NPM DEBUGGING===" +npm install -g npm@10 + +echo "===POST: NPM DEBUGGING===" +which npm +whereis npm +npm -v +echo npm config get update-notifier + +echo "===RUN: NPM DEBUGGING===" + + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -32,12 +59,19 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then + echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ + + echo "===2: NPM DEBUGGING===" npm link ../ + + echo "===3: NPM DEBUGGING===" npm install + + echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -51,7 +85,10 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi + echo "===5: NPM DEBUGGING===" npm run samples-test + + echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -62,7 +99,12 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi + + echo "===7: NPM DEBUGGING===" + bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi + +echo "===DONE: NPM DEBUGGING===" From 1ad1c59ab4db3f3e958f4bcd794ade77ac995f41 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Wed, 23 Oct 2024 12:05:40 -0700 Subject: [PATCH 22/34] chore: npm debugging --- .kokoro/samples-test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 2d1aaf91..eefafb62 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -21,8 +21,8 @@ echo "$NPM_CONFIG_PREFIX" ( echo "===UPDATE NOTIFIER: NPM DEBUGGING===" - echo npm config get update-notifier - echo npm config set update-notifier false + npm config get update-notifier || true + npm config set update-notifier false || true ) export NPM_CONFIG_PREFIX=${HOME}/.npm-global From ccc7a31df7523e335f4189e949e1b6bf96397bbc Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 23 Oct 2024 19:07:46 +0000 Subject: [PATCH 23/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 42 ----------------------------------------- 1 file changed, 42 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index eefafb62..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,35 +16,8 @@ set -eo pipefail -echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" -echo "$NPM_CONFIG_PREFIX" - -( - echo "===UPDATE NOTIFIER: NPM DEBUGGING===" - npm config get update-notifier || true - npm config set update-notifier false || true -) - export NPM_CONFIG_PREFIX=${HOME}/.npm-global -echo "===PRE: NPM DEBUGGING===" -which npm -whereis npm -npm -v -echo npm config get update-notifier - -echo "===INSTALL: NPM DEBUGGING===" -npm install -g npm@10 - -echo "===POST: NPM DEBUGGING===" -which npm -whereis npm -npm -v -echo npm config get update-notifier - -echo "===RUN: NPM DEBUGGING===" - - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -59,19 +32,12 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then - echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ - - echo "===2: NPM DEBUGGING===" npm link ../ - - echo "===3: NPM DEBUGGING===" npm install - - echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -85,10 +51,7 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi - echo "===5: NPM DEBUGGING===" npm run samples-test - - echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -99,12 +62,7 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi - - echo "===7: NPM DEBUGGING===" - bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi - -echo "===DONE: NPM DEBUGGING===" From ae96e08461adcd2cce97d46b38c075340d504f1c Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Thu, 24 Oct 2024 12:37:48 -0700 Subject: [PATCH 24/34] chore: additional debug logs --- .github/.OwlBot.lock.yaml | 2 +- .kokoro/samples-test.sh | 47 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index bda9384d..51868547 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -14,4 +14,4 @@ docker: image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest digest: sha256:bd8b41503cfcbd21f121e4b197d0f8bf1447f3499921f18441bb7e6e3ae8f7fa -# created: 2024-10-04T00:09:31.22876583Z +# created: 2024-10-10T00:00:00.00000000Z diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..9834f10d 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,8 +16,40 @@ set -eo pipefail +echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" +echo "$NPM_CONFIG_PREFIX" +which npm +whereis npm +npm -v + +( + echo "===UPDATE NOTIFIER: NPM DEBUGGING===" + npm config get update-notifier + npm config -g get update-notifier +) + export NPM_CONFIG_PREFIX=${HOME}/.npm-global +echo "===PRE: NPM DEBUGGING===" +which npm +whereis npm +npm -v +npm config get update-notifier +npm config -g get update-notifier + +echo "===INSTALL: NPM DEBUGGING===" +npm install -g npm@10 + +echo "===POST: NPM DEBUGGING===" +which npm +whereis npm +npm -v +npm config get update-notifier +npm config -g get update-notifier + +echo "===RUN: NPM DEBUGGING===" + + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -32,12 +64,19 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then + echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ + + echo "===2: NPM DEBUGGING===" npm link ../ + + echo "===3: NPM DEBUGGING===" npm install + + echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -51,7 +90,10 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi + echo "===5: NPM DEBUGGING===" npm run samples-test + + echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -62,7 +104,12 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi + + echo "===7: NPM DEBUGGING===" + bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi + +echo "===DONE: NPM DEBUGGING===" From fb5544d78d51c2d4aa810d7e0373691de7aba313 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 24 Oct 2024 19:40:08 +0000 Subject: [PATCH 25/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 47 ----------------------------------------- 1 file changed, 47 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 9834f10d..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,40 +16,8 @@ set -eo pipefail -echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" -echo "$NPM_CONFIG_PREFIX" -which npm -whereis npm -npm -v - -( - echo "===UPDATE NOTIFIER: NPM DEBUGGING===" - npm config get update-notifier - npm config -g get update-notifier -) - export NPM_CONFIG_PREFIX=${HOME}/.npm-global -echo "===PRE: NPM DEBUGGING===" -which npm -whereis npm -npm -v -npm config get update-notifier -npm config -g get update-notifier - -echo "===INSTALL: NPM DEBUGGING===" -npm install -g npm@10 - -echo "===POST: NPM DEBUGGING===" -which npm -whereis npm -npm -v -npm config get update-notifier -npm config -g get update-notifier - -echo "===RUN: NPM DEBUGGING===" - - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 @@ -64,19 +32,12 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then - echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ - - echo "===2: NPM DEBUGGING===" npm link ../ - - echo "===3: NPM DEBUGGING===" npm install - - echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -90,10 +51,7 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi - echo "===5: NPM DEBUGGING===" npm run samples-test - - echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -104,12 +62,7 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi - - echo "===7: NPM DEBUGGING===" - bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi - -echo "===DONE: NPM DEBUGGING===" From be5c154c25173053679b64baf3d93140b224f0ba Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Thu, 24 Oct 2024 12:48:00 -0700 Subject: [PATCH 26/34] chore: remove `NPM_CONFIG_PREFIX` --- .kokoro/browser-test.sh | 2 -- .kokoro/docs.sh | 2 -- .kokoro/lint.sh | 2 -- .kokoro/publish.sh | 4 +--- .kokoro/release/docs-devsite.sh | 1 - .kokoro/release/docs.sh | 3 --- .kokoro/samples-test.sh | 2 -- .kokoro/system-test.sh | 2 -- .kokoro/test.sh | 2 -- 9 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.kokoro/browser-test.sh b/.kokoro/browser-test.sh index d881d4c1..f8ca0f45 100755 --- a/.kokoro/browser-test.sh +++ b/.kokoro/browser-test.sh @@ -16,8 +16,6 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=/home/node/.npm-global - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/service-account.json export GCLOUD_PROJECT=long-door-651 diff --git a/.kokoro/docs.sh b/.kokoro/docs.sh index 85901242..87466f2f 100755 --- a/.kokoro/docs.sh +++ b/.kokoro/docs.sh @@ -16,8 +16,6 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global - cd $(dirname $0)/.. npm install diff --git a/.kokoro/lint.sh b/.kokoro/lint.sh index aef4866e..28efcd2f 100755 --- a/.kokoro/lint.sh +++ b/.kokoro/lint.sh @@ -16,8 +16,6 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global - cd $(dirname $0)/.. npm install diff --git a/.kokoro/publish.sh b/.kokoro/publish.sh index ca1d47af..427f2e50 100755 --- a/.kokoro/publish.sh +++ b/.kokoro/publish.sh @@ -16,8 +16,6 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global - # Start the releasetool reporter python3 -m releasetool publish-reporter-script > /tmp/publisher-script; source /tmp/publisher-script @@ -39,4 +37,4 @@ npm publish --access=public --registry=https://wombat-dressing-room.appspot.com # so we can generate SBOMs and attestations. # However, we *don't* want Kokoro to collect package-lock.json and *.tgz files # that happened to be installed with dependencies. -find node_modules -name package-lock.json -o -name "*.tgz" | xargs rm -f \ No newline at end of file +find node_modules -name package-lock.json -o -name "*.tgz" | xargs rm -f diff --git a/.kokoro/release/docs-devsite.sh b/.kokoro/release/docs-devsite.sh index 81a89f6c..ef4873de 100755 --- a/.kokoro/release/docs-devsite.sh +++ b/.kokoro/release/docs-devsite.sh @@ -19,7 +19,6 @@ set -eo pipefail if [[ -z "$CREDENTIALS" ]]; then # if CREDENTIALS are explicitly set, assume we're testing locally # and don't set NPM_CONFIG_PREFIX. - export NPM_CONFIG_PREFIX=${HOME}/.npm-global export PATH="$PATH:${NPM_CONFIG_PREFIX}/bin" cd $(dirname $0)/../.. fi diff --git a/.kokoro/release/docs.sh b/.kokoro/release/docs.sh index e9079a60..7f425f8d 100755 --- a/.kokoro/release/docs.sh +++ b/.kokoro/release/docs.sh @@ -18,9 +18,6 @@ set -eo pipefail # build jsdocs (Python is installed on the Node 18 docker image). if [[ -z "$CREDENTIALS" ]]; then - # if CREDENTIALS are explicitly set, assume we're testing locally - # and don't set NPM_CONFIG_PREFIX. - export NPM_CONFIG_PREFIX=${HOME}/.npm-global export PATH="$PATH:${NPM_CONFIG_PREFIX}/bin" cd $(dirname $0)/../.. fi diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..782be742 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,8 +16,6 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 diff --git a/.kokoro/system-test.sh b/.kokoro/system-test.sh index a90d5cfe..b7632391 100755 --- a/.kokoro/system-test.sh +++ b/.kokoro/system-test.sh @@ -16,8 +16,6 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 diff --git a/.kokoro/test.sh b/.kokoro/test.sh index 0d9f6392..527dc5d6 100755 --- a/.kokoro/test.sh +++ b/.kokoro/test.sh @@ -16,8 +16,6 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global - cd $(dirname $0)/.. npm install From 7f1ee3a818c208bdf916cbe566ed4b81e8c2097f Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 24 Oct 2024 19:50:16 +0000 Subject: [PATCH 27/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/docs.sh | 2 ++ .kokoro/lint.sh | 2 ++ .kokoro/publish.sh | 4 +++- .kokoro/release/docs-devsite.sh | 1 + .kokoro/release/docs.sh | 3 +++ .kokoro/samples-test.sh | 2 ++ .kokoro/system-test.sh | 2 ++ .kokoro/test.sh | 2 ++ 8 files changed, 17 insertions(+), 1 deletion(-) diff --git a/.kokoro/docs.sh b/.kokoro/docs.sh index 87466f2f..85901242 100755 --- a/.kokoro/docs.sh +++ b/.kokoro/docs.sh @@ -16,6 +16,8 @@ set -eo pipefail +export NPM_CONFIG_PREFIX=${HOME}/.npm-global + cd $(dirname $0)/.. npm install diff --git a/.kokoro/lint.sh b/.kokoro/lint.sh index 28efcd2f..aef4866e 100755 --- a/.kokoro/lint.sh +++ b/.kokoro/lint.sh @@ -16,6 +16,8 @@ set -eo pipefail +export NPM_CONFIG_PREFIX=${HOME}/.npm-global + cd $(dirname $0)/.. npm install diff --git a/.kokoro/publish.sh b/.kokoro/publish.sh index 427f2e50..ca1d47af 100755 --- a/.kokoro/publish.sh +++ b/.kokoro/publish.sh @@ -16,6 +16,8 @@ set -eo pipefail +export NPM_CONFIG_PREFIX=${HOME}/.npm-global + # Start the releasetool reporter python3 -m releasetool publish-reporter-script > /tmp/publisher-script; source /tmp/publisher-script @@ -37,4 +39,4 @@ npm publish --access=public --registry=https://wombat-dressing-room.appspot.com # so we can generate SBOMs and attestations. # However, we *don't* want Kokoro to collect package-lock.json and *.tgz files # that happened to be installed with dependencies. -find node_modules -name package-lock.json -o -name "*.tgz" | xargs rm -f +find node_modules -name package-lock.json -o -name "*.tgz" | xargs rm -f \ No newline at end of file diff --git a/.kokoro/release/docs-devsite.sh b/.kokoro/release/docs-devsite.sh index ef4873de..81a89f6c 100755 --- a/.kokoro/release/docs-devsite.sh +++ b/.kokoro/release/docs-devsite.sh @@ -19,6 +19,7 @@ set -eo pipefail if [[ -z "$CREDENTIALS" ]]; then # if CREDENTIALS are explicitly set, assume we're testing locally # and don't set NPM_CONFIG_PREFIX. + export NPM_CONFIG_PREFIX=${HOME}/.npm-global export PATH="$PATH:${NPM_CONFIG_PREFIX}/bin" cd $(dirname $0)/../.. fi diff --git a/.kokoro/release/docs.sh b/.kokoro/release/docs.sh index 7f425f8d..e9079a60 100755 --- a/.kokoro/release/docs.sh +++ b/.kokoro/release/docs.sh @@ -18,6 +18,9 @@ set -eo pipefail # build jsdocs (Python is installed on the Node 18 docker image). if [[ -z "$CREDENTIALS" ]]; then + # if CREDENTIALS are explicitly set, assume we're testing locally + # and don't set NPM_CONFIG_PREFIX. + export NPM_CONFIG_PREFIX=${HOME}/.npm-global export PATH="$PATH:${NPM_CONFIG_PREFIX}/bin" cd $(dirname $0)/../.. fi diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 782be742..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,6 +16,8 @@ set -eo pipefail +export NPM_CONFIG_PREFIX=${HOME}/.npm-global + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 diff --git a/.kokoro/system-test.sh b/.kokoro/system-test.sh index b7632391..a90d5cfe 100755 --- a/.kokoro/system-test.sh +++ b/.kokoro/system-test.sh @@ -16,6 +16,8 @@ set -eo pipefail +export NPM_CONFIG_PREFIX=${HOME}/.npm-global + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account export GCLOUD_PROJECT=long-door-651 diff --git a/.kokoro/test.sh b/.kokoro/test.sh index 527dc5d6..0d9f6392 100755 --- a/.kokoro/test.sh +++ b/.kokoro/test.sh @@ -16,6 +16,8 @@ set -eo pipefail +export NPM_CONFIG_PREFIX=${HOME}/.npm-global + cd $(dirname $0)/.. npm install From de9963717be8f91aadf126288c2792ad937d5e3d Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Thu, 24 Oct 2024 14:20:55 -0700 Subject: [PATCH 28/34] chore: more debugging --- .kokoro/samples-test.sh | 52 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..060304c8 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,7 +16,44 @@ set -eo pipefail +echo "USER: $USER" +echo "HOME: $HOME" + +echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" +echo "$NPM_CONFIG_PREFIX" +which npm +whereis npm +npm -v + +( + echo "===UPDATE NOTIFIER: NPM DEBUGGING===" + npm config get update-notifier + npm config -g get update-notifier +) + export NPM_CONFIG_PREFIX=${HOME}/.npm-global +echo "$USER" +echo "$HOME" + +echo "===PRE: NPM DEBUGGING===" +which npm +whereis npm +npm -v +npm config get update-notifier +npm config -g get update-notifier + +echo "===INSTALL: NPM DEBUGGING===" +npm install -g npm@10 + +echo "===POST: NPM DEBUGGING===" +which npm +whereis npm +npm -v +npm config get update-notifier +npm config -g get update-notifier + +echo "===RUN: NPM DEBUGGING===" + # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account @@ -32,12 +69,19 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then + echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ + + echo "===2: NPM DEBUGGING===" npm link ../ + + echo "===3: NPM DEBUGGING===" npm install + + echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -51,7 +95,10 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi + echo "===5: NPM DEBUGGING===" npm run samples-test + + echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -62,7 +109,12 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi + + echo "===7: NPM DEBUGGING===" + bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi + +echo "===DONE: NPM DEBUGGING===" From 703f733daeafd05ad6e64a7940e682c433c43112 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 24 Oct 2024 21:23:01 +0000 Subject: [PATCH 29/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 52 ----------------------------------------- 1 file changed, 52 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index 060304c8..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,44 +16,7 @@ set -eo pipefail -echo "USER: $USER" -echo "HOME: $HOME" - -echo "===NPM_CONFIG_PREFIX: NPM DEBUGGING===" -echo "$NPM_CONFIG_PREFIX" -which npm -whereis npm -npm -v - -( - echo "===UPDATE NOTIFIER: NPM DEBUGGING===" - npm config get update-notifier - npm config -g get update-notifier -) - export NPM_CONFIG_PREFIX=${HOME}/.npm-global -echo "$USER" -echo "$HOME" - -echo "===PRE: NPM DEBUGGING===" -which npm -whereis npm -npm -v -npm config get update-notifier -npm config -g get update-notifier - -echo "===INSTALL: NPM DEBUGGING===" -npm install -g npm@10 - -echo "===POST: NPM DEBUGGING===" -which npm -whereis npm -npm -v -npm config get update-notifier -npm config -g get update-notifier - -echo "===RUN: NPM DEBUGGING===" - # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account @@ -69,19 +32,12 @@ if [ -f .kokoro/pre-samples-test.sh ]; then fi if [ -f samples/package.json ]; then - echo "===1: NPM DEBUGGING===" npm install # Install and link samples cd samples/ - - echo "===2: NPM DEBUGGING===" npm link ../ - - echo "===3: NPM DEBUGGING===" npm install - - echo "===4: NPM DEBUGGING===" cd .. # If tests are running against main branch, configure flakybot # to open issues on failures: @@ -95,10 +51,7 @@ if [ -f samples/package.json ]; then trap cleanup EXIT HUP fi - echo "===5: NPM DEBUGGING===" npm run samples-test - - echo "===6: NPM DEBUGGING===" fi # codecov combines coverage across integration and unit tests. Include @@ -109,12 +62,7 @@ if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then if [ -f "$NYC_BIN" ]; then $NYC_BIN report || true fi - - echo "===7: NPM DEBUGGING===" - bash $KOKORO_GFILE_DIR/codecov.sh else echo "coverage is only reported for Node $COVERAGE_NODE" fi - -echo "===DONE: NPM DEBUGGING===" From b462b3447f4459f50da5e6c2d8c021f1ba6f3890 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Thu, 24 Oct 2024 15:29:52 -0700 Subject: [PATCH 30/34] chore: `npm` set prefix --- .kokoro/samples-test.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..c0607964 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,7 +16,8 @@ set -eo pipefail -export NPM_CONFIG_PREFIX=${HOME}/.npm-global +npm config -g get prefix +npm config -g set prefix "${HOME}/.npm-global" # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From a3e57ed634d6fe0c283b68486121fd7c49947d7e Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 24 Oct 2024 22:32:25 +0000 Subject: [PATCH 31/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c0607964..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,8 +16,7 @@ set -eo pipefail -npm config -g get prefix -npm config -g set prefix "${HOME}/.npm-global" +export NPM_CONFIG_PREFIX=${HOME}/.npm-global # Setup service account credentials. export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account From 6e0375d1f3817f9c2461bb76e9b39cec06ba5560 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Thu, 24 Oct 2024 15:35:45 -0700 Subject: [PATCH 32/34] chore: npm@10 --- .kokoro/samples-test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index c1cb0fc7..a0ce6e0e 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,6 +16,7 @@ set -eo pipefail +npm i -g npm@10 export NPM_CONFIG_PREFIX=${HOME}/.npm-global # Setup service account credentials. From f864734a091ca1cba6a478cd8c24b37b30c453e9 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 24 Oct 2024 22:38:01 +0000 Subject: [PATCH 33/34] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .kokoro/samples-test.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/.kokoro/samples-test.sh b/.kokoro/samples-test.sh index a0ce6e0e..c1cb0fc7 100755 --- a/.kokoro/samples-test.sh +++ b/.kokoro/samples-test.sh @@ -16,7 +16,6 @@ set -eo pipefail -npm i -g npm@10 export NPM_CONFIG_PREFIX=${HOME}/.npm-global # Setup service account credentials. From 695e95277670afe0fd703cbb54c093ee1974ebc6 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Thu, 24 Oct 2024 16:11:13 -0700 Subject: [PATCH 34/34] chore: use pre script for npm i for now --- .kokoro/pre-samples-test.sh | 1 + 1 file changed, 1 insertion(+) create mode 100644 .kokoro/pre-samples-test.sh diff --git a/.kokoro/pre-samples-test.sh b/.kokoro/pre-samples-test.sh new file mode 100644 index 00000000..e104e8ff --- /dev/null +++ b/.kokoro/pre-samples-test.sh @@ -0,0 +1 @@ +npm i -g npm@10