Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Update OAuth2Client Endpoints to JWT Versions #1762

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix!: Update OAuth2Client Endpoints to JWT Versions #1762

wants to merge 7 commits into from

Conversation

danielbankhead
Copy link
Contributor

@danielbankhead danielbankhead commented Feb 27, 2024 •
edited
Loading

The PEM endpoints have been long-deprecated and are causing issues for customers.

As a dependency, added JWK support to NodeCrypto.

Related:

Fixes: #1756 🦕

@d-goog
fix: Update OAuth2Client Endpoints
6c5b4ff 
- Default to JWK endpoint rather than long-deprecated PEM
@danielbankhead danielbankhead requested review from a team as code owners February 27, 2024 22:26
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 27, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 28, 2024
@danielbankhead danielbankhead changed the title fix: Update OAuth2Client Endpoints fix!: Update OAuth2Client Endpoints Feb 28, 2024
@danielbankhead danielbankhead changed the title fix!: Update OAuth2Client Endpoints fix!: Update OAuth2Client Endpoints to JWT Versions Feb 28, 2024
@danielbankhead danielbankhead added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 28, 2024
@danielbankhead
Copy link
Contributor Author

Requires Node 16+.

@danielbankhead danielbankhead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 28, 2024
@danielbankhead danielbankhead mentioned this pull request Feb 28, 2024
Open
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@danielbankhead danielbankhead added the next major: breaking change this is a change that we should wait to bundle into the next major version label Mar 13, 2024
@danielbankhead danielbankhead mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
2 participants
@danielbankhead @d-goog