ci: fix windows+cmake+x86 builds #14318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14318 +/- ##
==========================================
+ Coverage 93.22% 93.77% +0.55%
==========================================
Files 2181 2268 +87
Lines 191080 201852 +10772
==========================================
+ Hits 178128 189296 +11168
+ Misses 12952 12556 -396 ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dbolduc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not enough to just write to
${{ matrix.arch }}-windows.cmake. Apparently thex86build builds some of the deps using thex64-windowstriplet and others as thex86-windowstriplet.Tested: https://github.com/googleapis/google-cloud-cpp/actions/runs/9452556490
This change is