Skip to content

Commit

Permalink
chore: cleanup gapicgen a bit (#7703)
Browse files Browse the repository at this point in the history
- remove generating module feature, only do this with owlbot now
- remove all confings no longer being generated
- remove generation of manifest, owlbot does this now
  • Loading branch information
codyoss authored Apr 7, 2023
1 parent 4fedc34 commit e660af8
Show file tree
Hide file tree
Showing 7 changed files with 163 additions and 2,095 deletions.
2 changes: 0 additions & 2 deletions internal/gapicgen/cmd/genbot/local.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ type localConfig struct {
onlyGapics bool
regenOnly bool
forceAll bool
genModule bool
genAlias bool
}

Expand Down Expand Up @@ -75,7 +74,6 @@ func genLocal(ctx context.Context, c localConfig) error {
LocalMode: true,
RegenOnly: c.regenOnly,
ForceAll: c.forceAll,
GenModule: c.genModule,
GenAlias: c.genAlias,
}
if _, err := generator.Generate(ctx, conf); err != nil {
Expand Down
2 changes: 0 additions & 2 deletions internal/gapicgen/cmd/genbot/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ func main() {
gapicToGenerate := flag.String("gapic", os.Getenv("GAPIC_TO_GENERATE"), `Specifies which gapic to generate. The value should be in the form of an import path (Ex: cloud.google.com/go/pubsub/apiv1). The default "" generates all gapics.`)
onlyGapics := flag.Bool("only-gapics", strToBool(os.Getenv("ONLY_GAPICS")), "Enabling stops regenerating genproto.")
regenOnly := flag.Bool("regen-only", strToBool(os.Getenv("REGEN_ONLY")), "Enabling means no vetting, manifest updates, or compilation.")
genModule := flag.Bool("generate-module", strToBool(os.Getenv("GENERATE_MODULE")), "Enabling means a new module will be generated for API being generated.")
genAlias := flag.Bool("generate-alias", strToBool(os.Getenv("GENERATE_ALIAS")), "Enabling means alias files will be generated.")

flag.Parse()
Expand All @@ -69,7 +68,6 @@ func main() {
onlyGapics: *onlyGapics,
regenOnly: *regenOnly,
forceAll: *forceAll,
genModule: *genModule,
genAlias: *genAlias,
}); err != nil {
log.Fatal(err)
Expand Down
Loading

0 comments on commit e660af8

Please sign in to comment.