Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): do not delay on final transaction attempt #10824

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix(datastore): do not delay on final transaction attempt #10824

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0485b40
fix(datastore): do not delay on final transaction attempt
sgp Aug 29, 2024
b7b692e
Merge branch 'main' into datastore-no-delay-last-txn
bhshkh Sep 5, 2024
a46d841
Merge branch 'main' into datastore-no-delay-last-txn
bhshkh Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions datastore/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,11 @@ func (c *Client) RunInTransaction(ctx context.Context, f func(tx *Transaction) e
return nil, err
}

// If this is the last attempt, exit without delaying.
if n+1 == settings.attempts {
return nil, err
}

// Check if error should be retried
code, errConvert := grpcStatusCode(retryErr)
if errConvert != nil && code == codes.ResourceExhausted {
Expand Down
Loading