Merge pull request #712 from mziccard/remove-throws

Remove redundant throws from services method signatures
googleapis · Mar 4, 2016 · 7eb957d · 7eb957d
2 parents 50750d4 + 8dd8786
commit 7eb957d
Show file tree

Hide file tree

Showing 12 changed files with 364 additions and 198 deletions.
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/BigQuery.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/BigQuery.java
@@ -457,35 +457,35 @@ public static QueryResultsOption maxWaitTime(long maxWaitTime) {
    *
    * @throws BigQueryException upon failure
    */
-  Dataset create(DatasetInfo dataset, DatasetOption... options) throws BigQueryException;
+  Dataset create(DatasetInfo dataset, DatasetOption... options);
 
   /**
    * Creates a new table.
    *
    * @throws BigQueryException upon failure
    */
-  Table create(TableInfo table, TableOption... options) throws BigQueryException;
+  Table create(TableInfo table, TableOption... options);
 
   /**
    * Creates a new job.
    *
    * @throws BigQueryException upon failure
    */
-  Job create(JobInfo job, JobOption... options) throws BigQueryException;
+  Job create(JobInfo job, JobOption... options);
 
   /**
    * Returns the requested dataset or {@code null} if not found.
    *
    * @throws BigQueryException upon failure
    */
-  Dataset getDataset(String datasetId, DatasetOption... options) throws BigQueryException;
+  Dataset getDataset(String datasetId, DatasetOption... options);
 
   /**
    * Returns the requested dataset or {@code null} if not found.
    *
    * @throws BigQueryException upon failure
    */
-  Dataset getDataset(DatasetId datasetId, DatasetOption... options) throws BigQueryException;
+  Dataset getDataset(DatasetId datasetId, DatasetOption... options);
 
   /**
    * Lists the project's datasets. This method returns partial information on each dataset
@@ -495,67 +495,67 @@ public static QueryResultsOption maxWaitTime(long maxWaitTime) {
    *
    * @throws BigQueryException upon failure
    */
-  Page<Dataset> listDatasets(DatasetListOption... options) throws BigQueryException;
+  Page<Dataset> listDatasets(DatasetListOption... options);
 
   /**
    * Deletes the requested dataset.
    *
    * @return {@code true} if dataset was deleted, {@code false} if it was not found
    * @throws BigQueryException upon failure
    */
-  boolean delete(String datasetId, DatasetDeleteOption... options) throws BigQueryException;
+  boolean delete(String datasetId, DatasetDeleteOption... options);
 
   /**
    * Deletes the requested dataset.
    *
    * @return {@code true} if dataset was deleted, {@code false} if it was not found
    * @throws BigQueryException upon failure
    */
-  boolean delete(DatasetId datasetId, DatasetDeleteOption... options) throws BigQueryException;
+  boolean delete(DatasetId datasetId, DatasetDeleteOption... options);
 
   /**
    * Deletes the requested table.
    *
    * @return {@code true} if table was deleted, {@code false} if it was not found
    * @throws BigQueryException upon failure
    */
-  boolean delete(String datasetId, String tableId) throws BigQueryException;
+  boolean delete(String datasetId, String tableId);
 
   /**
    * Deletes the requested table.
    *
    * @return {@code true} if table was deleted, {@code false} if it was not found
    * @throws BigQueryException upon failure
    */
-  boolean delete(TableId tableId) throws BigQueryException;
+  boolean delete(TableId tableId);
 
   /**
    * Updates dataset information.
    *
    * @throws BigQueryException upon failure
    */
-  Dataset update(DatasetInfo dataset, DatasetOption... options) throws BigQueryException;
+  Dataset update(DatasetInfo dataset, DatasetOption... options);
 
   /**
    * Updates table information.
    *
    * @throws BigQueryException upon failure
    */
-  Table update(TableInfo table, TableOption... options) throws BigQueryException;
+  Table update(TableInfo table, TableOption... options);
 
   /**
    * Returns the requested table or {@code null} if not found.
    *
    * @throws BigQueryException upon failure
    */
-  Table getTable(String datasetId, String tableId, TableOption... options) throws BigQueryException;
+  Table getTable(String datasetId, String tableId, TableOption... options);
 
   /**
    * Returns the requested table or {@code null} if not found.
    *
    * @throws BigQueryException upon failure
    */
-  Table getTable(TableId tableId, TableOption... options) throws BigQueryException;
+  Table getTable(TableId tableId, TableOption... options);
 
   /**
    * Lists the tables in the dataset. This method returns partial information on each table
@@ -566,7 +566,7 @@ public static QueryResultsOption maxWaitTime(long maxWaitTime) {
    *
    * @throws BigQueryException upon failure
    */
-  Page<Table> listTables(String datasetId, TableListOption... options) throws BigQueryException;
+  Page<Table> listTables(String datasetId, TableListOption... options);
 
   /**
    * Lists the tables in the dataset. This method returns partial information on each table
@@ -577,51 +577,50 @@ public static QueryResultsOption maxWaitTime(long maxWaitTime) {
    *
    * @throws BigQueryException upon failure
    */
-  Page<Table> listTables(DatasetId datasetId, TableListOption... options) throws BigQueryException;
+  Page<Table> listTables(DatasetId datasetId, TableListOption... options);
 
   /**
    * Sends an insert all request.
    *
    * @throws BigQueryException upon failure
    */
-  InsertAllResponse insertAll(InsertAllRequest request) throws BigQueryException;
+  InsertAllResponse insertAll(InsertAllRequest request);
 
   /**
    * Lists the table's rows.
    *
    * @throws BigQueryException upon failure
    */
   Page<List<FieldValue>> listTableData(String datasetId, String tableId,
-      TableDataListOption... options) throws BigQueryException;
+      TableDataListOption... options);
 
   /**
    * Lists the table's rows.
    *
    * @throws BigQueryException upon failure
    */
-  Page<List<FieldValue>> listTableData(TableId tableId, TableDataListOption... options)
-      throws BigQueryException;
+  Page<List<FieldValue>> listTableData(TableId tableId, TableDataListOption... options);
 
   /**
    * Returns the requested job or {@code null} if not found.
    *
    * @throws BigQueryException upon failure
    */
-  Job getJob(String jobId, JobOption... options) throws BigQueryException;
+  Job getJob(String jobId, JobOption... options);
 
   /**
    * Returns the requested job or {@code null} if not found.
    *
    * @throws BigQueryException upon failure
    */
-  Job getJob(JobId jobId, JobOption... options) throws BigQueryException;
+  Job getJob(JobId jobId, JobOption... options);
 
   /**
    * Lists the jobs.
    *
    * @throws BigQueryException upon failure
    */
-  Page<Job> listJobs(JobListOption... options) throws BigQueryException;
+  Page<Job> listJobs(JobListOption... options);
 
   /**
    * Sends a job cancel request. This call will return immediately. The job status can then be
@@ -632,7 +631,7 @@ Page<List<FieldValue>> listTableData(TableId tableId, TableDataListOption... opt
    *     found
    * @throws BigQueryException upon failure
    */
-  boolean cancel(String jobId) throws BigQueryException;
+  boolean cancel(String jobId);
 
   /**
    * Sends a job cancel request. This call will return immediately. The job status can then be
@@ -643,21 +642,21 @@ Page<List<FieldValue>> listTableData(TableId tableId, TableDataListOption... opt
    *     found
    * @throws BigQueryException upon failure
    */
-  boolean cancel(JobId tableId) throws BigQueryException;
+  boolean cancel(JobId tableId);
 
   /**
    * Runs the query associated with the request.
    *
    * @throws BigQueryException upon failure
    */
-  QueryResponse query(QueryRequest request) throws BigQueryException;
+  QueryResponse query(QueryRequest request);
 
   /**
    * Returns results of the query associated with the provided job.
    *
    * @throws BigQueryException upon failure
    */
-  QueryResponse getQueryResults(JobId job, QueryResultsOption... options) throws BigQueryException;
+  QueryResponse getQueryResults(JobId job, QueryResultsOption... options);
 
   /**
    * Returns a channel to write data to be inserted into a BigQuery table. Data format and other