Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for README code in google-cloud-examples/ #623

Closed
ajkannan opened this issue Feb 5, 2016 · 6 comments
Closed

Add tests for README code in google-cloud-examples/ #623

ajkannan opened this issue Feb 5, 2016 · 6 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ajkannan
Copy link

ajkannan commented Feb 5, 2016

It would be nice to test that the commands we run in gcloud-java/gcloud-java-examples/README work. We could do this by creating a script that runs each command and parses the output looking for errors.
@ajkannan ajkannan added type: question Request for information or clarification. Not an issue. testing labels Feb 5, 2016
@mziccard mziccard mentioned this issue Jul 21, 2016
Merged
@lesv
Copy link
Contributor

lesv commented Jul 21, 2016

+1 This should be required for all new products, and we should go back and update all past modules.

@lesv
Copy link
Contributor

lesv commented Jul 21, 2016 •
edited
Loading

@jgeewax This should be required for all new products, and we should go back and update all past modules.

Also, this bug was for the gcloud-java-examples repo - which hasn't been updated in 6 months, I was speaking for the files in the gcloud-java-examples folder.

@mziccard
Copy link
Contributor

Also, this bug was for the gcloud-java-examples repo

I believe this issue refers to our gcloud-java-examples module, not some other repo.

@garrettjonesgoogle garrettjonesgoogle added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 18, 2017
@garrettjonesgoogle garrettjonesgoogle changed the title Should we run tests for gcloud-java-examples in Travis? Add tests for README code in google-cloud-examples/ Aug 14, 2017
@garrettjonesgoogle garrettjonesgoogle added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: question Request for information or clarification. Not an issue. labels Aug 14, 2017
@yihanzhen
Copy link
Contributor

The feature request is added to the backlog. The issue will be closed but is linked in the backlog and can continue to be used for comment and discussion.

@yihanzhen
Copy link
Contributor

I'm no longer working on this repo :p

Reopening the issue for the team to triage.

@yihanzhen yihanzhen reopened this Feb 1, 2021
@yihanzhen yihanzhen removed their assignment Feb 1, 2021
@meredithslota
Copy link

I get a 404 from https://github.com/googleapis/google-cloud-java/tree/main/gcloud-java-examples and given the shift towards having all samples tested, I would expect that this is no longer relevant. Closing, but feel free to reopen with another repro repo.

github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v23 (g…
cc541be 
…oogleapis#623)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `22.0.0` -> `23.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/23.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/23.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/23.0.0/compatibility-slim/22.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/23.0.0/confidence-slim/22.0.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit that referenced this issue Jul 14, 2022
@release-please
chore(main): release 2.5.1 (#623)
a0faa7b 
🤖 I have created a release *beep* *boop*
---


## [2.5.1](googleapis/java-monitoring-dashboards@v2.5.0...v2.5.1) (2022-07-13)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-monitoring-dashboards/issues/1485)) ([#622](googleapis/java-monitoring-dashboards#622)) ([019f96a](googleapis/java-monitoring-dashboards@019f96a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this issue Feb 1, 2023
@meltsufin
chore: fix link to documentation (#720)
0461594 
Fixes: #623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mziccard @lesv @meredithslota @ajkannan @garrettjonesgoogle @yihanzhen