Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RemoteLoggingHelper and integration tests #1111

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Add RemoteLoggingHelper and integration tests #1111

merged 1 commit into from
Jul 18, 2016

Conversation

mziccard
Copy link
Contributor

No description provided.

@mziccard mziccard added the api: logging Issues related to the Cloud Logging API. label Jul 14, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2016
@mziccard
Copy link
Contributor Author

@lesv here are the integration tests (and helper class) we were all waiting for!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 84.35% when pulling 91fc21a on mziccard:logging-its into e3321a7 on GoogleCloudPlatform:logging-alpha.

lesv
lesv reviewed Jul 15, 2016
View reviewed changes
gcloud-java-logging/pom.xml
@@ -18,6 +18,11 @@
</properties>
<dependencies>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative-boringssl-static</artifactId>
<version>1.1.33.Fork17</version>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lesv
Copy link
Contributor

lesv commented Jul 15, 2016

LGTM

@lesv
Copy link
Contributor

lesv commented Jul 18, 2016

Totally cool w/ that Fork17

@mziccard mziccard merged commit 708245e into googleapis:logging-alpha Jul 18, 2016
mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jul 20, 2016
@mziccard
Add RemoteLoggingHelper and integration tests (googleapis#1111)
6f5e3af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mziccard @coveralls @lesv @googlebot