Add BaseEmulatorHelper class and tests, refactor helper classes #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mziccard
force-pushed
the
refactor-helpers
branch
from
9216288 to
fb0e269
Compare
mziccard
force-pushed
the
refactor-helpers
branch
from
fb0e269 to
bfb875e
Compare
| * Returns the emulator runners supported by this emulator. Runners are evaluated in order, the | ||
| * first available runner is selected and executed | ||
| */ | ||
| protected abstract List<EmulatorRunner> emulatorRunners(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return currentVersion != null && currentVersion.compareTo(minVersion) >= 0; | ||
| } | ||
|
|
||
| private Version installedEmulatorVersion(String versionPrefix) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| /** | ||
| * Utility class to start and stop a local service which is used by unit testing. | ||
| */ | ||
| public abstract class BaseEmulatorHelper<T extends ServiceOptions> { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
This was referenced Nov 9, 2016
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
* chore: upgrade black to 22.3.0 * update lint also * run blacken session * ci: use click>8.0 for blacken/lint sessions * chore: fix typo Co-authored-by: nicain <nicholascain@google.com> * rebase error Co-authored-by: nicain <nicholascain@google.com> Source-Link: googleapis/synthtool@0dcf739 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:4a8d2d787ea374ba929e37c39c4b16d2498044e24ef123077125b946cac2dcdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.