pubsub: clarify subscriber shutdown doc #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the doc, we just wait for done.get() to return before closing the Subscriber. This commit makes clear that done.get() in the doc is an example condition. Updates #2485.
googlebot
added
the
cla: yes
jabubake
approved these changes
Oct 9, 2017
schmidt-sebastian
pushed a commit
to FirebasePrivate/google-cloud-java
that referenced
this pull request
Nov 9, 2017
In the doc, we just wait for done.get() to return before closing the Subscriber. This commit makes clear that done.get() in the doc is an example condition. Updates googleapis#2485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the doc, we just wait for done.get() to return before closing the
Subscriber.
This commit makes clear that done.get() in the doc is an example
condition.
Updates #2485.