Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace com.google.api.client.util.Lists with Guava's Lists #694

Merged
merged 2 commits into from
Mar 1, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented Mar 1, 2016

No description provided.

@mziccard mziccard added the type: cleanup An internal cleanup or hygiene concern. label Mar 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2016
@ajkannan
Copy link

ajkannan commented Mar 1, 2016

Do you think it's worth adding to this CL related changes, i.e. changing com.google.api.client.util.DateTime in BucketInfo to joda?

Two additional cleanup changes could include:

  • BucketInfo uses the wrong checkNotNull static import
  • BlobInfo uses api client DateTime

@mziccard
Copy link
Contributor Author

mziccard commented Mar 1, 2016

BucketInfo and BlobInfo use DateTime because the proto objects timestamps are actually DateTime fields.

@mziccard
Copy link
Contributor Author

mziccard commented Mar 1, 2016

Fixed checkNotNull inclusion in 6e87fa9

@ajkannan
Copy link

ajkannan commented Mar 1, 2016

Looks like there are merge conflicts, but other than that, looks good to me.

aozarov added a commit that referenced this pull request Mar 1, 2016
Replace com.google.api.client.util.Lists with Guava's Lists
@aozarov aozarov merged commit 926831e into googleapis:master Mar 1, 2016
@aozarov
Copy link
Contributor

aozarov commented Mar 1, 2016

BTW, though codacy is great it any more automation that we can do to check our code which is not supported by it would be really nice.

I was wondering if we could actually write our own "verify code" script that would run on Travis (as part of the standard build) that would check the code (e.g. for any use of "repackaged") and would use the github statuses API to communicate the result of our checks. Also see this.

github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
…4.0 (#694)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `25.3.0` -> `25.4.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.4.0/compatibility-slim/25.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.4.0/confidence-slim/25.3.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
…is#694)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 456641589

Source-Link: googleapis/googleapis@8a251f5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
)

* chore: update dependencies for regapic

* add more dependencies and trigger comment

* update goldens

* fix indentation

* remove duplicate gax-httpjson dependency

* remove duplicated dependencies
Source-Link: googleapis/synthtool@fa54eb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
🤖 I have created a release *beep* *boop*
---


## [2.2.0](googleapis/java-os-login@v2.1.0...v2.2.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#694](googleapis/java-os-login#694)) ([a82410e](googleapis/java-os-login@a82410e))


### Bug Fixes

* make java.base fields accessible to fix java 17 runtime errors.  ([googleapis#688](googleapis/java-os-login#688)) ([51a9a6f](googleapis/java-os-login@51a9a6f))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#693](googleapis/java-os-login#693)) ([ecb4469](googleapis/java-os-login@ecb4469))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
…-info-reports-plugin to v3.4.0 (#694)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-project-info-reports-plugin)) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-servicedirectory).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
…-info-reports-plugin to v3.4.0 (#694)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigqueryreservation).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
github-actions bot pushed a commit that referenced this pull request Aug 16, 2022
…to v2.2.2 (#694)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-webrisk](https://togithub.com/googleapis/java-webrisk) | `2.2.0` -> `2.2.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-webrisk/2.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-webrisk/2.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-webrisk/2.2.2/compatibility-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-webrisk/2.2.2/confidence-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-webrisk).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE1My4wIn0=-->
github-actions bot pushed a commit that referenced this pull request Aug 16, 2022
…-plugin to v3.4.1 (#694)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-billing).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE1OS4xIn0=-->
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
🤖 I have created a release *beep* *boop*
---


## [0.123.16](https://togithub.com/googleapis/java-notification/compare/v0.123.15...v0.123.16) (2022-10-02)


### Dependencies

* Update dependency cachetools to v5 ([#710](https://togithub.com/googleapis/java-notification/issues/710)) ([31aa092](https://togithub.com/googleapis/java-notification/commit/31aa092db94e7e6ed2341dc2566c30f5d845b212))
* Update dependency certifi to v2022.9.24 ([#690](https://togithub.com/googleapis/java-notification/issues/690)) ([ed4a6ea](https://togithub.com/googleapis/java-notification/commit/ed4a6eaa78b3722c65a666787aec83c409db0976))
* Update dependency charset-normalizer to v2.1.1 ([#695](https://togithub.com/googleapis/java-notification/issues/695)) ([cdac448](https://togithub.com/googleapis/java-notification/commit/cdac4481bc2a3da94b9efa5eaa9f578fea4093d6))
* Update dependency click to v8.1.3 ([#696](https://togithub.com/googleapis/java-notification/issues/696)) ([bde844c](https://togithub.com/googleapis/java-notification/commit/bde844cacd41e0aa9d0661b63e8477ce07c14cb0))
* Update dependency gcp-releasetool to v1.8.8 ([#691](https://togithub.com/googleapis/java-notification/issues/691)) ([5d01c3c](https://togithub.com/googleapis/java-notification/commit/5d01c3c76499b8c1bd50954f6b9e504cbb52e3f0))
* Update dependency gcp-releasetool to v1.8.9 ([#718](https://togithub.com/googleapis/java-notification/issues/718)) ([63d3f22](https://togithub.com/googleapis/java-notification/commit/63d3f2233556f70cfaea5cea87aad8cde8f7d9e7))
* Update dependency google-api-core to v2.10.1 ([#697](https://togithub.com/googleapis/java-notification/issues/697)) ([e6751a2](https://togithub.com/googleapis/java-notification/commit/e6751a2a2567742abd451b4a8722942effbc5e84))
* Update dependency google-auth to v2.11.1 ([#692](https://togithub.com/googleapis/java-notification/issues/692)) ([f70af38](https://togithub.com/googleapis/java-notification/commit/f70af38d05d2a6da5aeca093d8dc97b797fc3bc9))
* Update dependency google-auth to v2.12.0 ([#713](https://togithub.com/googleapis/java-notification/issues/713)) ([40b7ac5](https://togithub.com/googleapis/java-notification/commit/40b7ac576f14c28f3f74ebaf641f7e23eaa435e5))
* Update dependency google-cloud-core to v2.3.2 ([#693](https://togithub.com/googleapis/java-notification/issues/693)) ([5624d7c](https://togithub.com/googleapis/java-notification/commit/5624d7ce52b2167dad2b1b511338d16809abcb5a))
* Update dependency google-cloud-storage to v2.5.0 ([#698](https://togithub.com/googleapis/java-notification/issues/698)) ([84a21a4](https://togithub.com/googleapis/java-notification/commit/84a21a446fff83ae1a715db76a2bbccd792724c8))
* Update dependency google-crc32c to v1.5.0 ([#699](https://togithub.com/googleapis/java-notification/issues/699)) ([ff95524](https://togithub.com/googleapis/java-notification/commit/ff95524970dd03ef00aea3cacbf358c37a542bfe))
* Update dependency google-resumable-media to v2.4.0 ([#714](https://togithub.com/googleapis/java-notification/issues/714)) ([a3d47b1](https://togithub.com/googleapis/java-notification/commit/a3d47b1dd90a1630967b85b1021784830419ec4c))
* Update dependency googleapis-common-protos to v1.56.4 ([#694](https://togithub.com/googleapis/java-notification/issues/694)) ([7895ac8](https://togithub.com/googleapis/java-notification/commit/7895ac8a1d82d202236131717c96a6541d2da31f))
* Update dependency importlib-metadata to v4.12.0 ([#700](https://togithub.com/googleapis/java-notification/issues/700)) ([41f614d](https://togithub.com/googleapis/java-notification/commit/41f614d07f1abf27ea1634201d4fde8bb8e2524e))
* Update dependency importlib-metadata to v4.13.0 ([#716](https://togithub.com/googleapis/java-notification/issues/716)) ([394ff31](https://togithub.com/googleapis/java-notification/commit/394ff318aa3284bba3a879063488e0a7ecb0a985))
* Update dependency importlib-metadata to v5 ([#717](https://togithub.com/googleapis/java-notification/issues/717)) ([05cb144](https://togithub.com/googleapis/java-notification/commit/05cb144ce0ad3031ea0034e152764c581709917f))
* Update dependency jeepney to v0.8.0 ([#701](https://togithub.com/googleapis/java-notification/issues/701)) ([ac9eace](https://togithub.com/googleapis/java-notification/commit/ac9eacecb3a4ae41461924ff64c5e9f24c7a4121))
* Update dependency jinja2 to v3.1.2 ([#702](https://togithub.com/googleapis/java-notification/issues/702)) ([345310b](https://togithub.com/googleapis/java-notification/commit/345310b7d7cda99b3891fad5be175cbccd65c1fc))
* Update dependency keyring to v23.9.3 ([#703](https://togithub.com/googleapis/java-notification/issues/703)) ([3201712](https://togithub.com/googleapis/java-notification/commit/32017121f16f4640b508a6409eeab4a54805d896))
* Update dependency protobuf to v3.20.2 ([#705](https://togithub.com/googleapis/java-notification/issues/705)) ([6b21e5f](https://togithub.com/googleapis/java-notification/commit/6b21e5f583e4825f4e77c3b6ee61ae94aa388be6))
* Update dependency protobuf to v3.20.3 ([#715](https://togithub.com/googleapis/java-notification/issues/715)) ([04cb62e](https://togithub.com/googleapis/java-notification/commit/04cb62e55340ca6f8fe54ea676eb664127d155b2))
* Update dependency protobuf to v4 ([#711](https://togithub.com/googleapis/java-notification/issues/711)) ([1cba250](https://togithub.com/googleapis/java-notification/commit/1cba250c4bff9c451aa5ce905295e0287b7e0a26))
* Update dependency pyjwt to v2.5.0 ([#706](https://togithub.com/googleapis/java-notification/issues/706)) ([cee2aed](https://togithub.com/googleapis/java-notification/commit/cee2aedc0fd7f5f273e2ab4a87476b453732caa1))
* Update dependency requests to v2.28.1 ([#707](https://togithub.com/googleapis/java-notification/issues/707)) ([faff885](https://togithub.com/googleapis/java-notification/commit/faff8852d4978e3e7c2c3d2ae7af8f2f3ec07e7e))
* Update dependency typing-extensions to v4.3.0 ([#708](https://togithub.com/googleapis/java-notification/issues/708)) ([fd41d12](https://togithub.com/googleapis/java-notification/commit/fd41d122d27a85a429182f79de18a1fff9b9581a))
* Update dependency zipp to v3.8.1 ([#709](https://togithub.com/googleapis/java-notification/issues/709)) ([98b5318](https://togithub.com/googleapis/java-notification/commit/98b5318636c0d2450a3e61fa1c8e369c13a95937))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Feb 1, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants