fix: better support for fallback mode (#49)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
googleapis · Aug 23, 2022 · 53e0d3d · 53e0d3d
1 parent bb3bd07
commit 53e0d3d
Show file tree

Hide file tree

Showing 7 changed files with 101 additions and 87 deletions.
diff --git a/packages/google-cloud-ids/samples/generated/v1/i_d_s.create_endpoint.js b/packages/google-cloud-ids/samples/generated/v1/i_d_s.create_endpoint.js
@@ -23,6 +23,9 @@
 function main(parent, endpointId, endpoint) {
   // [START ids_v1_generated_IDS_CreateEndpoint_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**

diff --git a/packages/google-cloud-ids/samples/generated/v1/i_d_s.delete_endpoint.js b/packages/google-cloud-ids/samples/generated/v1/i_d_s.delete_endpoint.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START ids_v1_generated_IDS_DeleteEndpoint_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**

diff --git a/packages/google-cloud-ids/samples/generated/v1/i_d_s.get_endpoint.js b/packages/google-cloud-ids/samples/generated/v1/i_d_s.get_endpoint.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START ids_v1_generated_IDS_GetEndpoint_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**

diff --git a/packages/google-cloud-ids/samples/generated/v1/i_d_s.list_endpoints.js b/packages/google-cloud-ids/samples/generated/v1/i_d_s.list_endpoints.js
@@ -23,6 +23,9 @@
 function main(parent) {
   // [START ids_v1_generated_IDS_ListEndpoints_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**

diff --git a/packages/google-cloud-ids/samples/generated/v1/snippet_metadata.google.cloud.ids.v1.json b/packages/google-cloud-ids/samples/generated/v1/snippet_metadata.google.cloud.ids.v1.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 74,
+                    "end": 77,
                     "type": "FULL"
                 }
             ],
@@ -78,7 +78,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -118,7 +118,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 80,
+                    "end": 83,
                     "type": "FULL"
                 }
             ],
@@ -170,7 +170,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 65,
+                    "end": 68,
                     "type": "FULL"
                 }
             ],

diff --git a/packages/google-cloud-ids/src/v1/i_d_s_client.ts b/packages/google-cloud-ids/src/v1/i_d_s_client.ts
@@ -30,7 +30,6 @@ import {
 } from 'google-gax';
 
 import {Transform} from 'stream';
-import {RequestType} from 'google-gax/build/src/apitypes';
 import * as protos from '../../protos/protos';
 import jsonProtos = require('../../protos/protos.json');
 /**
@@ -346,7 +345,8 @@ export class IDSClient {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
@@ -646,7 +646,7 @@ export class IDSClient {
     const decodeOperation = new gax.Operation(
       operation,
       this.descriptors.longrunning.createEndpoint,
-      gax.createDefaultBackoffSettings()
+      this._gaxModule.createDefaultBackoffSettings()
     );
     return decodeOperation as LROperation<
       protos.google.cloud.ids.v1.Endpoint,
@@ -797,7 +797,7 @@ export class IDSClient {
     const decodeOperation = new gax.Operation(
       operation,
       this.descriptors.longrunning.deleteEndpoint,
-      gax.createDefaultBackoffSettings()
+      this._gaxModule.createDefaultBackoffSettings()
     );
     return decodeOperation as LROperation<
       protos.google.protobuf.Empty,
@@ -955,7 +955,7 @@ export class IDSClient {
     const callSettings = defaultCallSettings.merge(options);
     this.initialize();
     return this.descriptors.page.listEndpoints.createStream(
-      this.innerApiCalls.listEndpoints as gax.GaxCall,
+      this.innerApiCalls.listEndpoints as GaxCall,
       request,
       callSettings
     );
@@ -1014,7 +1014,7 @@ export class IDSClient {
     this.initialize();
     return this.descriptors.page.listEndpoints.asyncIterate(
       this.innerApiCalls['listEndpoints'] as GaxCall,
-      request as unknown as RequestType,
+      request as {},
       callSettings
     ) as AsyncIterable<protos.google.cloud.ids.v1.IEndpoint>;
   }

diff --git a/packages/google-cloud-ids/test/gapic_i_d_s_v1.ts b/packages/google-cloud-ids/test/gapic_i_d_s_v1.ts
@@ -145,99 +145,101 @@ function stubAsyncIterationCall<ResponseType>(
 }
 
 describe('v1.IDSClient', () => {
-  it('has servicePath', () => {
-    const servicePath = idsModule.v1.IDSClient.servicePath;
-    assert(servicePath);
-  });
-
-  it('has apiEndpoint', () => {
-    const apiEndpoint = idsModule.v1.IDSClient.apiEndpoint;
-    assert(apiEndpoint);
-  });
-
-  it('has port', () => {
-    const port = idsModule.v1.IDSClient.port;
-    assert(port);
-    assert(typeof port === 'number');
-  });
-
-  it('should create a client with no option', () => {
-    const client = new idsModule.v1.IDSClient();
-    assert(client);
-  });
+  describe('Common methods', () => {
+    it('has servicePath', () => {
+      const servicePath = idsModule.v1.IDSClient.servicePath;
+      assert(servicePath);
+    });
 
-  it('should create a client with gRPC fallback', () => {
-    const client = new idsModule.v1.IDSClient({
-      fallback: true,
+    it('has apiEndpoint', () => {
+      const apiEndpoint = idsModule.v1.IDSClient.apiEndpoint;
+      assert(apiEndpoint);
     });
-    assert(client);
-  });
 
-  it('has initialize method and supports deferred initialization', async () => {
-    const client = new idsModule.v1.IDSClient({
-      credentials: {client_email: 'bogus', private_key: 'bogus'},
-      projectId: 'bogus',
+    it('has port', () => {
+      const port = idsModule.v1.IDSClient.port;
+      assert(port);
+      assert(typeof port === 'number');
     });
-    assert.strictEqual(client.iDSStub, undefined);
-    await client.initialize();
-    assert(client.iDSStub);
-  });
 
-  it('has close method for the initialized client', done => {
-    const client = new idsModule.v1.IDSClient({
-      credentials: {client_email: 'bogus', private_key: 'bogus'},
-      projectId: 'bogus',
+    it('should create a client with no option', () => {
+      const client = new idsModule.v1.IDSClient();
+      assert(client);
     });
-    client.initialize();
-    assert(client.iDSStub);
-    client.close().then(() => {
-      done();
+
+    it('should create a client with gRPC fallback', () => {
+      const client = new idsModule.v1.IDSClient({
+        fallback: true,
+      });
+      assert(client);
     });
-  });
 
-  it('has close method for the non-initialized client', done => {
-    const client = new idsModule.v1.IDSClient({
-      credentials: {client_email: 'bogus', private_key: 'bogus'},
-      projectId: 'bogus',
+    it('has initialize method and supports deferred initialization', async () => {
+      const client = new idsModule.v1.IDSClient({
+        credentials: {client_email: 'bogus', private_key: 'bogus'},
+        projectId: 'bogus',
+      });
+      assert.strictEqual(client.iDSStub, undefined);
+      await client.initialize();
+      assert(client.iDSStub);
     });
-    assert.strictEqual(client.iDSStub, undefined);
-    client.close().then(() => {
-      done();
+
+    it('has close method for the initialized client', done => {
+      const client = new idsModule.v1.IDSClient({
+        credentials: {client_email: 'bogus', private_key: 'bogus'},
+        projectId: 'bogus',
+      });
+      client.initialize();
+      assert(client.iDSStub);
+      client.close().then(() => {
+        done();
+      });
     });
-  });
 
-  it('has getProjectId method', async () => {
-    const fakeProjectId = 'fake-project-id';
-    const client = new idsModule.v1.IDSClient({
-      credentials: {client_email: 'bogus', private_key: 'bogus'},
-      projectId: 'bogus',
+    it('has close method for the non-initialized client', done => {
+      const client = new idsModule.v1.IDSClient({
+        credentials: {client_email: 'bogus', private_key: 'bogus'},
+        projectId: 'bogus',
+      });
+      assert.strictEqual(client.iDSStub, undefined);
+      client.close().then(() => {
+        done();
+      });
     });
-    client.auth.getProjectId = sinon.stub().resolves(fakeProjectId);
-    const result = await client.getProjectId();
-    assert.strictEqual(result, fakeProjectId);
-    assert((client.auth.getProjectId as SinonStub).calledWithExactly());
-  });
 
-  it('has getProjectId method with callback', async () => {
-    const fakeProjectId = 'fake-project-id';
-    const client = new idsModule.v1.IDSClient({
-      credentials: {client_email: 'bogus', private_key: 'bogus'},
-      projectId: 'bogus',
+    it('has getProjectId method', async () => {
+      const fakeProjectId = 'fake-project-id';
+      const client = new idsModule.v1.IDSClient({
+        credentials: {client_email: 'bogus', private_key: 'bogus'},
+        projectId: 'bogus',
+      });
+      client.auth.getProjectId = sinon.stub().resolves(fakeProjectId);
+      const result = await client.getProjectId();
+      assert.strictEqual(result, fakeProjectId);
+      assert((client.auth.getProjectId as SinonStub).calledWithExactly());
     });
-    client.auth.getProjectId = sinon
-      .stub()
-      .callsArgWith(0, null, fakeProjectId);
-    const promise = new Promise((resolve, reject) => {
-      client.getProjectId((err?: Error | null, projectId?: string | null) => {
-        if (err) {
-          reject(err);
-        } else {
-          resolve(projectId);
-        }
+
+    it('has getProjectId method with callback', async () => {
+      const fakeProjectId = 'fake-project-id';
+      const client = new idsModule.v1.IDSClient({
+        credentials: {client_email: 'bogus', private_key: 'bogus'},
+        projectId: 'bogus',
+      });
+      client.auth.getProjectId = sinon
+        .stub()
+        .callsArgWith(0, null, fakeProjectId);
+      const promise = new Promise((resolve, reject) => {
+        client.getProjectId((err?: Error | null, projectId?: string | null) => {
+          if (err) {
+            reject(err);
+          } else {
+            resolve(projectId);
+          }
+        });
       });
+      const result = await promise;
+      assert.strictEqual(result, fakeProjectId);
     });
-    const result = await promise;
-    assert.strictEqual(result, fakeProjectId);
   });
 
   describe('getEndpoint', () => {