From 305381ff555a82340c6dc5f2e5a6f9d7ca756596 Mon Sep 17 00:00:00 2001 From: Ryan Seys Date: Wed, 11 Mar 2015 00:02:48 -0400 Subject: [PATCH] Remove possibility of race conditions in pubsub reg tests --- regression/pubsub.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/regression/pubsub.js b/regression/pubsub.js index 3a1bace86dd..e23a4635a14 100644 --- a/regression/pubsub.js +++ b/regression/pubsub.js @@ -200,7 +200,7 @@ describe('pubsub', function() { assert.ifError(err); subscription.pull({ - returnImmediately: true, + returnImmediately: false, maxResults: 1 }, function(err, msgs) { assert.ifError(err); @@ -216,10 +216,11 @@ describe('pubsub', function() { assert.ifError(err); subscription.pull({ - returnImmediately: true, + returnImmediately: false, maxResults: 1 }, function(err, msgs) { assert.ifError(err); + var options = { ackId: msgs[0].ackId, seconds: 10 @@ -247,7 +248,7 @@ describe('pubsub', function() { assert.ifError(err); subscription.pull({ - returnImmediately: true, + returnImmediately: false, maxResults: 1 }, function(err, msgs) { assert.ifError(err); @@ -275,7 +276,7 @@ describe('pubsub', function() { assert.ifError(err); subscription.pull({ - returnImmediately: true, + returnImmediately: false, maxResults: 1 }, function(err, msgs) { assert.ifError(err); @@ -287,7 +288,7 @@ describe('pubsub', function() { it('should receive the chosen amount of results', function(done) { var subscription = topic.subscription(SUB_NAMES[1]); - var opts = { returnImmediately: true, maxResults: 3 }; + var opts = { returnImmediately: false, maxResults: 3 }; topic.publish([ { data: 'hello' },