Skip to content

Commit 16e88f2

Browse files
tswastparthea
authored andcommitted
Add dependency for resource proto. (#7585)
Turns out that without the latest googleapis-common-protos all the tests pass, but Sphinx docs builds still fail. Remove the hack I added to exclude this dependency and bump the minimum version of googleapis-common-protos instead.
1 parent 00ff094 commit 16e88f2

File tree

4 files changed

+6
-17
lines changed

4 files changed

+6
-17
lines changed

packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-bigquery-storage/setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
release_status = 'Development Status :: 3 - Alpha'
2626
dependencies = [
2727
'google-api-core[grpc] >= 1.6.0, < 2.0.0dev',
28+
'googleapis-common-protos >= 1.5.9, < 2.0.0dev',
2829
'enum34; python_version < "3.4"',
2930
]
3031
extras = {

packages/google-cloud-bigquery-storage/synth.metadata

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"updateTime": "2019-03-25T21:54:47.957767Z",
2+
"updateTime": "2019-03-27T17:44:10.575389Z",
33
"sources": [
44
{
55
"generator": {
@@ -12,8 +12,8 @@
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "git@github.com:googleapis/googleapis.git",
15-
"sha": "e80435a132c53da26f46daf0787035ee63fb942b",
16-
"internalRef": "239938670"
15+
"sha": "d4d57d766601105478c661132f2687e6984b92d5",
16+
"internalRef": "240469931"
1717
}
1818
}
1919
],

packages/google-cloud-bigquery-storage/synth.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,6 @@
4242
],
4343
)
4444

45-
# START: Remove unnecessary dependency on google.api.resource protos.
46-
s.replace(
47-
["google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py"],
48-
"from google.api import resource_pb2 as google_dot_api_dot_resource__pb2\n",
49-
"",
50-
)
51-
52-
s.replace(
53-
["google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py"],
54-
"google_dot_api_dot_resource__pb2.DESCRIPTOR,",
55-
"",
56-
)
57-
# END: Remove unnecessary dependency on google.api.resource protos.
58-
5945
s.replace(
6046
[
6147
"google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py",

0 commit comments

Comments
 (0)