Skip to content

Commit 3fd72e2

Browse files
committed
Fix Py3k failures.
1 parent 03b4442 commit 3fd72e2

File tree

1 file changed

+24
-10
lines changed

1 file changed

+24
-10
lines changed

gcloud/translate/test_client.py

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,11 @@ def test_detect_language_bad_result(self):
138138
req = conn._requested[0]
139139
self.assertEqual(req['method'], 'GET')
140140
self.assertEqual(req['path'], '/detect')
141-
self.assertEqual(req['query_params'],
142-
[('key', self.KEY), ('q', value)])
141+
query_params = [
142+
('key', self.KEY),
143+
('q', value.encode('utf-8')),
144+
]
145+
self.assertEqual(req['query_params'], query_params)
143146

144147
def test_detect_language_single_value(self):
145148
client = self._makeOne(self.KEY)
@@ -165,8 +168,11 @@ def test_detect_language_single_value(self):
165168
req = conn._requested[0]
166169
self.assertEqual(req['method'], 'GET')
167170
self.assertEqual(req['path'], '/detect')
168-
self.assertEqual(req['query_params'],
169-
[('key', self.KEY), ('q', value)])
171+
query_params = [
172+
('key', self.KEY),
173+
('q', value.encode('utf-8')),
174+
]
175+
self.assertEqual(req['query_params'], query_params)
170176

171177
def test_detect_language_multiple_values(self):
172178
client = self._makeOne(self.KEY)
@@ -205,7 +211,7 @@ def test_detect_language_multiple_values(self):
205211
query_params = [
206212
('key', self.KEY),
207213
('q', value1.encode('utf-8')),
208-
('q', value2),
214+
('q', value2.encode('utf-8')),
209215
]
210216
self.assertEqual(req['query_params'], query_params)
211217

@@ -247,8 +253,12 @@ def test_translate_bad_result(self):
247253
req = conn._requested[0]
248254
self.assertEqual(req['method'], 'GET')
249255
self.assertEqual(req['path'], '')
250-
self.assertEqual(req['query_params'],
251-
[('key', self.KEY), ('target', 'en'), ('q', value)])
256+
query_params = [
257+
('key', self.KEY),
258+
('target', 'en'),
259+
('q', value.encode('utf-8')),
260+
]
261+
self.assertEqual(req['query_params'], query_params)
252262

253263
def test_translate_defaults(self):
254264
client = self._makeOne(self.KEY)
@@ -273,8 +283,12 @@ def test_translate_defaults(self):
273283
req = conn._requested[0]
274284
self.assertEqual(req['method'], 'GET')
275285
self.assertEqual(req['path'], '')
276-
self.assertEqual(req['query_params'],
277-
[('key', self.KEY), ('target', 'en'), ('q', value)])
286+
query_params = [
287+
('key', self.KEY),
288+
('target', 'en'),
289+
('q', value.encode('utf-8')),
290+
]
291+
self.assertEqual(req['query_params'], query_params)
278292

279293
def test_translate_explicit(self):
280294
client = self._makeOne(self.KEY)
@@ -307,7 +321,7 @@ def test_translate_explicit(self):
307321
query_params = [
308322
('key', self.KEY),
309323
('target', target_language),
310-
('q', value),
324+
('q', value.encode('utf-8')),
311325
('cid', cid),
312326
('format', format_),
313327
('source', source_language),

0 commit comments

Comments
 (0)