From fd3df423174bf05cbc62d9db3cd24569c876ac3f Mon Sep 17 00:00:00 2001 From: Yoshi Automation Bot Date: Wed, 23 Dec 2020 08:15:49 -0800 Subject: [PATCH] chore: exclude `.nox/` from linting; update python versions in CONTRIBUTING (#44) * docs(python): document adding Python 3.9 support, dropping 3.5 support Closes #787 Source-Author: Tres Seaver Source-Date: Thu Dec 17 16:08:02 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: b670a77a454f415d247907908e8ee7943e06d718 Source-Link: https://github.com/googleapis/synthtool/commit/b670a77a454f415d247907908e8ee7943e06d718 * chore: exclude `.nox` directories from linting The samples tests create `.nox` directories with all dependencies installed. These directories should be excluded from linting. I've tested this change locally, and it significantly speeds up linting on my machine. Source-Author: Tim Swast Source-Date: Tue Dec 22 13:04:04 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 373861061648b5fe5e0ac4f8a38b32d639ee93e4 Source-Link: https://github.com/googleapis/synthtool/commit/373861061648b5fe5e0ac4f8a38b32d639ee93e4 --- packages/google-cloud-phishing-protection/.flake8 | 1 + .../google-cloud-phishing-protection/CONTRIBUTING.rst | 11 +++++------ .../google-cloud-phishing-protection/synth.metadata | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/google-cloud-phishing-protection/.flake8 b/packages/google-cloud-phishing-protection/.flake8 index ed9316381c9c..29227d4cf419 100644 --- a/packages/google-cloud-phishing-protection/.flake8 +++ b/packages/google-cloud-phishing-protection/.flake8 @@ -26,6 +26,7 @@ exclude = *_pb2.py # Standard linting exemptions. + **/.nox/** __pycache__, .git, *.pyc, diff --git a/packages/google-cloud-phishing-protection/CONTRIBUTING.rst b/packages/google-cloud-phishing-protection/CONTRIBUTING.rst index 9dd196aca247..24a168724377 100644 --- a/packages/google-cloud-phishing-protection/CONTRIBUTING.rst +++ b/packages/google-cloud-phishing-protection/CONTRIBUTING.rst @@ -21,8 +21,8 @@ In order to add a feature: - The feature must be documented in both the API and narrative documentation. -- The feature must work fully on the following CPython versions: 2.7, - 3.5, 3.6, 3.7 and 3.8 on both UNIX and Windows. +- The feature must work fully on the following CPython versions: + 3.6, 3.7, 3.8 and 3.9 on both UNIX and Windows. - The feature must not add unnecessary dependencies (where "unnecessary" is of course subjective, but new dependencies should @@ -202,25 +202,24 @@ Supported Python Versions We support: -- `Python 3.5`_ - `Python 3.6`_ - `Python 3.7`_ - `Python 3.8`_ +- `Python 3.9`_ -.. _Python 3.5: https://docs.python.org/3.5/ .. _Python 3.6: https://docs.python.org/3.6/ .. _Python 3.7: https://docs.python.org/3.7/ .. _Python 3.8: https://docs.python.org/3.8/ +.. _Python 3.9: https://docs.python.org/3.9/ Supported versions can be found in our ``noxfile.py`` `config`_. .. _config: https://github.com/googleapis/python-phishingprotection/blob/master/noxfile.py -Python 2.7 support is deprecated. All code changes should maintain Python 2.7 compatibility until January 1, 2020. We also explicitly decided to support Python 3 beginning with version -3.5. Reasons for this include: +3.6. Reasons for this include: - Encouraging use of newest versions of Python 3 - Taking the lead of `prominent`_ open-source `projects`_ diff --git a/packages/google-cloud-phishing-protection/synth.metadata b/packages/google-cloud-phishing-protection/synth.metadata index ae935211c7d6..7b0723f32afa 100644 --- a/packages/google-cloud-phishing-protection/synth.metadata +++ b/packages/google-cloud-phishing-protection/synth.metadata @@ -4,7 +4,7 @@ "git": { "name": ".", "remote": "https://github.com/googleapis/python-phishingprotection.git", - "sha": "197a75346252441e5a5cb5eee982e7cb64a20299" + "sha": "e587e30187c88b252664a0f39d1860cc9eed98ea" } }, { @@ -19,7 +19,7 @@ "git": { "name": "synthtool", "remote": "https://github.com/googleapis/synthtool.git", - "sha": "aa255b15d52b6d8950cca48cfdf58f7d27a60c8a" + "sha": "373861061648b5fe5e0ac4f8a38b32d639ee93e4" } } ],