From cddb59293a20d3a50a0f536a965edd84810632f3 Mon Sep 17 00:00:00 2001 From: Peter Lamut Date: Fri, 10 Jan 2020 16:08:27 +0000 Subject: [PATCH 1/2] Adjust request params assertion in test (timeout) --- runtimeconfig/tests/unit/test__http.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/runtimeconfig/tests/unit/test__http.py b/runtimeconfig/tests/unit/test__http.py index 041afd32a15e..34aa94f56cb8 100644 --- a/runtimeconfig/tests/unit/test__http.py +++ b/runtimeconfig/tests/unit/test__http.py @@ -62,5 +62,9 @@ def test_extra_headers(self): } expected_uri = conn.build_api_url("/rainbow") http.request.assert_called_once_with( - data=req_data, headers=expected_headers, method="GET", url=expected_uri + data=req_data, + headers=expected_headers, + method="GET", + url=expected_uri, + timeout=None, ) From c17058cd46616c2c981e05146666dea2ae699dca Mon Sep 17 00:00:00 2001 From: Peter Lamut Date: Fri, 10 Jan 2020 16:09:14 +0000 Subject: [PATCH 2/2] Update version pin for core dependency Version bump is needed, as timeouts were introduced to API core. --- runtimeconfig/setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtimeconfig/setup.py b/runtimeconfig/setup.py index e519f14b6666..9edded19128e 100644 --- a/runtimeconfig/setup.py +++ b/runtimeconfig/setup.py @@ -29,7 +29,7 @@ # 'Development Status :: 5 - Production/Stable' release_status = 'Development Status :: 3 - Alpha' dependencies = [ - "google-cloud-core >= 1.0.3, < 2.0dev", + "google-cloud-core >= 1.1.0, < 2.0dev", ] extras = { }