Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Oct 27, 2025

Fixes #14686
Closes #14806

Towards googleapis/librarian#2456

BEGIN_COMMIT_OVERRIDE
feat: Add support for Python 3.14
fix: Deprecate credentials_file argument
fix(deps): Require grpcio >= 1.33.2
fix(deps): Require grpcio >= 1.75.1 for Python 3.14
END_COMMIT_OVERRIDE

@parthea parthea force-pushed the re-generate-google-cloud-bigquery-storage branch from 3040dfc to ee436eb Compare October 27, 2025 21:57
@parthea parthea marked this pull request as ready for review October 27, 2025 21:58
@parthea parthea requested a review from a team as a code owner October 27, 2025 21:58
@parthea parthea requested a review from GaoleMeng October 27, 2025 21:58
@parthea parthea force-pushed the re-generate-google-cloud-bigquery-storage branch from ee436eb to 2ea9f8c Compare October 27, 2025 22:00
@parthea parthea force-pushed the re-generate-google-cloud-bigquery-storage branch from 02039ba to 2fbb1a3 Compare October 27, 2025 23:13
@parthea
Copy link
Contributor Author

parthea commented Oct 27, 2025

2fbb1a3 which restored samples/__init__.py fixed the following error

==================================== ERRORS ====================================
_______ ERROR collecting samples/pyarrow/append_rows_with_arrow_test.py ________
samples/pyarrow/append_rows_with_arrow_test.py:15: in 
    from . import append_rows_with_arrow
samples/pyarrow/append_rows_with_arrow.py:19: in 
    from google.cloud import bigquery
.nox/system-3-12/lib/python3.12/site-packages/google/cloud/bigquery/__init__.py:36: in 
    from google.cloud.bigquery.client import Client
.nox/system-3-12/lib/python3.12/site-packages/google/cloud/bigquery/client.py:65: in 
    from google.cloud.bigquery_storage_v1.services.big_query_read.client import (
google/cloud/bigquery_storage_v1/__init__.py:20: in 
    from google.cloud.bigquery_storage_v1 import client, types
google/cloud/bigquery_storage_v1/client.py:28: in 
    from google.cloud.bigquery_storage_v1 import reader
google/cloud/bigquery_storage_v1/reader.py:30: in 
    import pandas
.nox/system-3-12/lib/python3.12/site-packages/pandas/__init__.py:26: in 
    from pandas.compat import (
.nox/system-3-12/lib/python3.12/site-packages/pandas/compat/__init__.py:29: in 
    from pandas.compat.pyarrow import (
.nox/system-3-12/lib/python3.12/site-packages/pandas/compat/pyarrow.py:10: in 
    _palv = Version(Version(pa.__version__).base_version)
                            ^^^^^^^^^^^^^^
E   AttributeError: module 'pyarrow' has no attribute '__version__'

are specified, the client will attempt to ascertain the
credentials from the environment.
credentials_file (Optional[str]): A file with credentials that can
credentials_file (Optional[str]): Deprecated. A file with credentials that can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: Will we update the templates to raise a warning when credentials_file is supplied? There's like 3 to pick from, but FutureWarning is the only one that's not ignored by default IIRC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning was added as part of google-api-core in https://github.com/googleapis/python-api-core/pull/841/files and is already being emitted for users that have updated google-api-core. I decided not to include another warning in templates in googleapis/gapic-generator-python#2454 as it could be considered a duplicate. I chose DeprecationWarning as it seemed like the best fit at the time, but you're right, FutureWarning seems to be the one that we should use for end users based on the description in https://docs.python.org/3/library/warnings.html#warning-categories. Since google-api-core was already released, it could be disruptive to change the warning type from DeprecationWarning to FutureWarning now but I'll keep this in mind for future work.

@parthea parthea merged commit bd0f542 into main Oct 28, 2025
27 checks passed
@parthea parthea deleted the re-generate-google-cloud-bigquery-storage branch October 28, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.14 support for google-cloud-bigquery-storage

3 participants