-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Add support for Python 3.14 #14811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3040dfc to
ee436eb
Compare
ee436eb to
2ea9f8c
Compare
02039ba to
2fbb1a3
Compare
|
2fbb1a3 which restored |
| are specified, the client will attempt to ascertain the | ||
| credentials from the environment. | ||
| credentials_file (Optional[str]): A file with credentials that can | ||
| credentials_file (Optional[str]): Deprecated. A file with credentials that can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: Will we update the templates to raise a warning when credentials_file is supplied? There's like 3 to pick from, but FutureWarning is the only one that's not ignored by default IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning was added as part of google-api-core in https://github.com/googleapis/python-api-core/pull/841/files and is already being emitted for users that have updated google-api-core. I decided not to include another warning in templates in googleapis/gapic-generator-python#2454 as it could be considered a duplicate. I chose DeprecationWarning as it seemed like the best fit at the time, but you're right, FutureWarning seems to be the one that we should use for end users based on the description in https://docs.python.org/3/library/warnings.html#warning-categories. Since google-api-core was already released, it could be disruptive to change the warning type from DeprecationWarning to FutureWarning now but I'll keep this in mind for future work.
Fixes #14686
Closes #14806
Towards googleapis/librarian#2456
BEGIN_COMMIT_OVERRIDE
feat: Add support for Python 3.14
fix: Deprecate
credentials_fileargumentfix(deps): Require grpcio >= 1.33.2
fix(deps): Require grpcio >= 1.75.1 for Python 3.14
END_COMMIT_OVERRIDE