-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add common_resources.proto #14851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+323
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
approved these changes
Nov 5, 2025
parthea
added a commit
that referenced
this pull request
Nov 5, 2025
The commit body is not needed when creating release notes. It was originally added to workaround googleapis/librarian#2234. As per googleapis/librarian#2234 (comment), we should not include the body in the release notes. Without the fix in this PR, the changelog for `googleapis-common-protos` looks like this ``` ## [1.72.0](googleapis-common-protos-v1.71.0...googleapis-common-protos-v1.72.0) (2025-11-05) ### Features * add common_resources.proto (#14851) This PR depends on #14850 `google/cloud` was not listed as an api path for `googleapis-common-protos` for code was not being generated for https://github.com/googleapis/googleapis/blob/master/google/cloud/extended_operations.proto and https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto ([e4e0e2a](e4e0e2a)) * add field api_version to message ServiceForTransport (#14843) This PR was created locally. The reason that this could not be automated is that the current directory structure [gapic/metadata](https://github.com/googleapis/googleapis/tree/master/gapic/metadata) doesn't align with the protobuf package name [google.gapic.metadata](https://github.com/googleapis/googleapis/blob/53af3b727f84acc34e31c23f3b6e7b8aa4b7e837/gapic/metadata/gapic_metadata.proto#L18). The expected directory structure for `google.gapic.metadata` is `google/gapic/metadata`. In the `googleapis-common-protos` package, the `gencode` is in the expected location ([81812fd](81812fd)) ``` With the fix, the changelog for `googleapis-common-protos` looks like this ``` ## [1.72.0](googleapis-common-protos-v1.71.0...googleapis-common-protos-v1.72.0) (2025-11-05) ### Features * add common_resources.proto (#14851) ([e4e0e2a](e4e0e2a)) * add field api_version to message ServiceForTransport (#14843) ([81812fd](81812fd)) ```
ohmayr
pushed a commit
that referenced
this pull request
Nov 6, 2025
Librarian Version: v0.0.0-20251022181450-0ee9437f0ec3 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:27eae7edfe88876a47cbdb89ec6491192706e94ce46ac0e3ff4d202ef3220fed <details><summary>google-ads-datamanager: 0.1.0</summary> ## [0.1.0](google-ads-datamanager-v0.0.0...google-ads-datamanager-v0.1.0) (2025-11-06) ### Features * onboard a new library (PiperOrigin-RevId: 822625565) ([8197d16](8197d16d)) </details> <details><summary>google-ads-marketingplatform-admin: 0.3.0</summary> ## [0.3.0](google-ads-marketingplatform-admin-v0.2.0...google-ads-marketingplatform-admin-v0.3.0) (2025-11-06) ### Features * add the `ListOrganizationsRequest` and `ListOrganizationsResponse` resources (PiperOrigin-RevId: 826146529) ([735dcad](735dcad1)) * add the `FindSalesPartnerManagedClientsRequest` and `FindSalesPartnerManagedClientsResponse` resources (PiperOrigin-RevId: 826146529) ([735dcad](735dcad1)) * define AnalyticsServiceLevel and AnalyticsPropertyType enums in resources.proto (PiperOrigin-RevId: 826146529) ([735dcad](735dcad1)) * add the `ListOrganizations`, `FindSalesPartnerManagedClients`, and `ReportPropertyUsage` methods (PiperOrigin-RevId: 826146529) ([735dcad](735dcad1)) * add the `ReportPropertyUsageRequest` and `ReportPropertyUsageResponse` resources (PiperOrigin-RevId: 826146529) ([735dcad](735dcad1)) * update OAuth scopes in marketingplatformadmin_v1alpha.yaml (PiperOrigin-RevId: 826146529) ([735dcad](735dcad1)) </details> <details><summary>google-cloud-backupdr: 0.4.0</summary> ## [0.4.0](google-cloud-backupdr-v0.3.0...google-cloud-backupdr-v0.4.0) (2025-11-06) ### Features * Adding `source_resource` fields to Backup resource (PiperOrigin-RevId: 827762328) ([735dcad](735dcad1)) * Adding `ListDataSourceReferences` API (PiperOrigin-RevId: 827762328) ([735dcad](735dcad1)) * Adding new workload specific fields for Cloud SQL (PiperOrigin-RevId: 827762328) ([735dcad](735dcad1)) * Adding `FetchBackupsForResourceType` API (PiperOrigin-RevId: 827762328) ([735dcad](735dcad1)) </details> <details><summary>google-cloud-bigquery-analyticshub: 0.6.0</summary> ## [0.6.0](google-cloud-bigquery-analyticshub-v0.5.0...google-cloud-bigquery-analyticshub-v0.6.0) (2025-11-06) ### Features * add Stored Procedure Sharing support for analyticshub listings (PiperOrigin-RevId: 827828462) ([735dcad](735dcad1)) * add tags support for Pub/Sub subscriptions (PiperOrigin-RevId: 827828462) ([735dcad](735dcad1)) </details> <details><summary>google-cloud-cloudsecuritycompliance: 0.4.0</summary> ## [0.4.0](google-cloud-cloudsecuritycompliance-v0.3.0...google-cloud-cloudsecuritycompliance-v0.4.0) (2025-11-06) ### Features * Adding client libraries for Monitoring API Compliance Manager Service (PiperOrigin-RevId: 825918020) ([735dcad](735dcad1)) * add Audit API surface (PiperOrigin-RevId: 824893251) ([a7ed700](a7ed7007)) ### Documentation * Updated docs for the APIs (PiperOrigin-RevId: 825918020) ([735dcad](735dcad1)) * Changes to few fields are also made (PiperOrigin-RevId: 824893251) ([a7ed700](a7ed7007)) </details> <details><summary>google-cloud-dataplex: 2.15.0</summary> ## [2.15.0](google-cloud-dataplex-v2.14.0...google-cloud-dataplex-v2.15.0) (2025-11-06) ### Features * Add GetIamPolicy method for DataProduct resources (PiperOrigin-RevId: 828293199) ([735dcad](735dcad1)) * Allow publishing Data Profile scan results to the Dataplex Catalog (PiperOrigin-RevId: 828293199) ([735dcad](735dcad1)) ### Documentation * Update documentation for Catalog SearchEntries filter options, including `parent_entry` and wildcard usage (PiperOrigin-RevId: 828293199) ([735dcad](735dcad1)) </details> <details><summary>google-cloud-hypercomputecluster: 0.1.0</summary> ## [0.1.0](google-cloud-hypercomputecluster-v0.0.0...google-cloud-hypercomputecluster-v0.1.0) (2025-11-06) ### Features * onboard a new library (PiperOrigin-RevId: 823382075) ([c0baa32](c0baa321)) </details> <details><summary>google-cloud-network-management: 1.30.0</summary> ## [1.30.0](google-cloud-network-management-v1.29.0...google-cloud-network-management-v1.30.0) (2025-11-06) ### Features * add enum `Status` to message `InstanceInfo` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add http additional_bindings (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add enum values `NO_ROUTE_FROM_EXTERNAL_IPV6_SOURCE_TO_PRIVATE_IPV6_ADDRESS`, `TRAFFIC_FROM_HYBRID_ENDPOINT_TO_INTERNET_DISALLOWED`, `NO_MATCHING_NAT64_GATEWAY`, `LOAD_BALANCER_BACKEND_IP_VERSION_MISMATCH`, and `NO_KNOWN_ROUTE_FROM_NCC_NETWORK_TO_DESTINATION` to `DropInfo.Cause` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * Enable organization-level support for VPC Flow Logs (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add field `running` to message `InstanceInfo` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add field `google_service_type` to message `DeliverInfo` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add enum `VpcFlowLogsConfig.TargetResourceState` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add enum value `AbortInfo.Cause.GOOGLE_MANAGED_SERVICE_AMBIGUOUS_ENDPOINT` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add enum `VpcFlowLogsConfig.CrossProjectMetadata` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add enum value `RouteInfo.NextHopType.SECURE_WEB_PROXY_GATEWAY` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add message `Endpoint.SingleEdgeResponse` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add enum `DeliverInfo.GoogleServiceType` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add rpc `VpcFlowLogsService.QueryOrgVpcFlowLogsConfigs` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add field `policy_priority` to message `NetworkInfo` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add fields `cross_project_metadata`, `target_resource_state`, `network`, and `subnet` to message `VpcFlowLogsConfig` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add service `OrganizationVpcFlowLogsService` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) * add field `service_uri` to message `Endpoint.CloudRunRevisionEndpoint` (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) ### Documentation * Various documentation and comment improvements, Enable organization-level support for VPC Flow Logs (PiperOrigin-RevId: 825895694) ([735dcad](735dcad1)) </details> <details><summary>google-cloud-network-services: 0.7.0</summary> ## [0.7.0](google-cloud-network-services-v0.6.0...google-cloud-network-services-v0.7.0) (2025-11-06) ### Features * Add support for LbEdgeExtension resource in NetworkServices API (PiperOrigin-RevId: 827499725) ([735dcad](735dcad1)) </details> <details><summary>google-cloud-translate: 3.23.0</summary> ## [3.23.0](google-cloud-translate-v3.22.0...google-cloud-translate-v3.23.0) (2025-11-06) ### Features * Adds support for RefineText (PiperOrigin-RevId: 828181593) ([735dcad](735dcad1)) * Adds option for pdf_native only document translation (PiperOrigin-RevId: 828181593) ([735dcad](735dcad1)) * Adds option for contextual translation with glossaries (PiperOrigin-RevId: 828181593) ([735dcad](735dcad1)) </details> <details><summary>google-shopping-merchant-datasources: 1.2.0</summary> ## [1.2.0](google-shopping-merchant-datasources-v1.1.0...google-shopping-merchant-datasources-v1.2.0) (2025-11-06) ### Bug Fixes * An existing field `contains_custom_rules` is removed from message `.google.shopping.merchant.datasources.v1.PrimaryProductDataSource` (PiperOrigin-RevId: 826368950) ([735dcad](735dcad1)) ### Documentation * update documentation for datasources (PiperOrigin-RevId: 826368950) ([735dcad](735dcad1)) </details> <details><summary>googleapis-common-protos: 1.72.0</summary> ## [1.72.0](googleapis-common-protos-v1.71.0...googleapis-common-protos-v1.72.0) (2025-11-06) ### Features * add common_resources.proto (#14851) ([e4e0e2a](e4e0e2a9)) * add field api_version to message ServiceForTransport (#14843) ([81812fd](81812fde)) </details> --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #14850
google/cloudwas not listed as an api path forgoogleapis-common-protosfor code was not being generated for https://github.com/googleapis/googleapis/blob/master/google/cloud/extended_operations.proto and https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto