From dd1d44add85df8324b982ecf535fcf32911e5430 Mon Sep 17 00:00:00 2001 From: Tres Seaver Date: Thu, 10 Mar 2016 17:01:53 -0500 Subject: [PATCH] Add 'Sink.update' API wrapper. --- gcloud/logging/sink.py | 18 +++++++++++++++++ gcloud/logging/test_sink.py | 39 +++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/gcloud/logging/sink.py b/gcloud/logging/sink.py index c817bc52ff7e..8b9d022f08e2 100644 --- a/gcloud/logging/sink.py +++ b/gcloud/logging/sink.py @@ -126,3 +126,21 @@ def reload(self, client=None): data = client.connection.api_request(method='GET', path=self.path) self.filter_ = data['filter'] self.destination = data['destination'] + + def update(self, client=None): + """API call: update sink configuration via a PUT request + + See + https://cloud.google.com/logging/docs/api/ref_v2beta1/rest/v2beta1/projects.sinks/update + + :type client: :class:`gcloud.logging.client.Client` or ``NoneType`` + :param client: the client to use. If not passed, falls back to the + ``client`` stored on the current sink. + """ + client = self._require_client(client) + data = { + 'name': self.name, + 'filter': self.filter_, + 'destination': self.destination, + } + client.connection.api_request(method='PUT', path=self.path, data=data) diff --git a/gcloud/logging/test_sink.py b/gcloud/logging/test_sink.py index 0869789a543a..7da704e96624 100644 --- a/gcloud/logging/test_sink.py +++ b/gcloud/logging/test_sink.py @@ -154,6 +154,45 @@ def test_reload_w_alternate_client(self): self.assertEqual(req['method'], 'GET') self.assertEqual(req['path'], '/%s' % FULL) + def test_update_w_bound_client(self): + FULL = 'projects/%s/sinks/%s' % (self.PROJECT, self.SINK_NAME) + RESOURCE = { + 'name': self.SINK_NAME, + 'filter': self.FILTER, + 'destination': self.DESTINATION_URI, + } + conn = _Connection(RESOURCE) + CLIENT = _Client(project=self.PROJECT, connection=conn) + sink = self._makeOne(self.SINK_NAME, self.FILTER, self.DESTINATION_URI, + client=CLIENT) + sink.update() + self.assertEqual(len(conn._requested), 1) + req = conn._requested[0] + self.assertEqual(req['method'], 'PUT') + self.assertEqual(req['path'], '/%s' % FULL) + self.assertEqual(req['data'], RESOURCE) + + def test_update_w_alternate_client(self): + FULL = 'projects/%s/sinks/%s' % (self.PROJECT, self.SINK_NAME) + RESOURCE = { + 'name': self.SINK_NAME, + 'filter': self.FILTER, + 'destination': self.DESTINATION_URI, + } + conn1 = _Connection() + CLIENT1 = _Client(project=self.PROJECT, connection=conn1) + conn2 = _Connection(RESOURCE) + CLIENT2 = _Client(project=self.PROJECT, connection=conn2) + sink = self._makeOne(self.SINK_NAME, self.FILTER, self.DESTINATION_URI, + client=CLIENT1) + sink.update(client=CLIENT2) + self.assertEqual(len(conn1._requested), 0) + self.assertEqual(len(conn2._requested), 1) + req = conn2._requested[0] + self.assertEqual(req['method'], 'PUT') + self.assertEqual(req['path'], '/%s' % FULL) + self.assertEqual(req['data'], RESOURCE) + class _Connection(object):