From 89bb2be1bbfb6b5592985e69c828cc0b4d153b1a Mon Sep 17 00:00:00 2001 From: Thomas Schultz Date: Fri, 17 Jun 2016 16:15:28 -0400 Subject: [PATCH 1/2] Fix IO Permissions on Appveyor. --- gcloud/test__helpers.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/gcloud/test__helpers.py b/gcloud/test__helpers.py index 1285776c06da..fdc01fddbdcc 100644 --- a/gcloud/test__helpers.py +++ b/gcloud/test__helpers.py @@ -166,13 +166,15 @@ def tearDown(self): def test_success(self): import os - import tempfile - with tempfile.NamedTemporaryFile(mode='w') as credential_file: - credential_file.write('{"project_id": "test-project-id"}') - credential_file.seek(0) - os.environ['GOOGLE_APPLICATION_CREDENTIALS'] = credential_file.name + from gcloud._testing import _NamedTemporaryFile - self.assertEqual('test-project-id', self._callFUT()) + with _NamedTemporaryFile() as temp: + with open(temp.name, mode='w') as creds_file: + creds_file.write('{"project_id": "test-project-id"}') + creds_file.seek(0) + os.environ['GOOGLE_APPLICATION_CREDENTIALS'] = creds_file.name + + self.assertEqual('test-project-id', self._callFUT()) def test_no_environment(self): self.assertEqual(None, self._callFUT()) @@ -184,9 +186,11 @@ class Test__get_default_service_project_id(unittest2.TestCase): config_file = 'config_default' def setUp(self): - import tempfile import os - self.temp_config_path = tempfile.gettempdir() + from gcloud._testing import _NamedTemporaryFile + + with _NamedTemporaryFile() as temp: + self.temp_config_path = os.path.dirname(temp.name) conf_path = os.path.join(self.temp_config_path, self.config_path) os.makedirs(conf_path) From 9aa5c307db8227206ed04a762397ad31722656e1 Mon Sep 17 00:00:00 2001 From: Thomas Schultz Date: Fri, 17 Jun 2016 17:27:52 -0400 Subject: [PATCH 2/2] Switch working test back to use tempfile. --- gcloud/test__helpers.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gcloud/test__helpers.py b/gcloud/test__helpers.py index fdc01fddbdcc..96e524d9d428 100644 --- a/gcloud/test__helpers.py +++ b/gcloud/test__helpers.py @@ -186,11 +186,9 @@ class Test__get_default_service_project_id(unittest2.TestCase): config_file = 'config_default' def setUp(self): + import tempfile import os - from gcloud._testing import _NamedTemporaryFile - - with _NamedTemporaryFile() as temp: - self.temp_config_path = os.path.dirname(temp.name) + self.temp_config_path = tempfile.gettempdir() conf_path = os.path.join(self.temp_config_path, self.config_path) os.makedirs(conf_path)