Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 29, 2016

Replacing it with the RTD template so we can still verify that the docs are valid Sphinx.

@daspecster LMK if any of the deleted files are still needed. AFAIK the old build is completely separate from the stuff you introduced, so these files were essentially "dead".

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2016
@tseaver
Copy link
Contributor

tseaver commented Aug 29, 2016

LGTM pending Travis.

Replacing it with the RTD template so we can still
verify that the docs are valid Sphinx.
@dhermes dhermes force-pushed the remove-non-rtd-sphinx branch from aa89a9b to 62184fe Compare August 29, 2016 22:27
@dhermes
Copy link
Contributor Author

dhermes commented Aug 29, 2016

Just deleted four more and folded into the original PR commit

        deleted:    scripts/get_version.py
        deleted:    scripts/update_docs.sh
        deleted:    scripts/update_versions.py
        deleted:    scripts/versions.html.template

@tseaver
Copy link
Contributor

tseaver commented Aug 30, 2016

"You may fire when you are ready, Gridley"

@daspecster
Copy link
Contributor

@dhermes, this looks ok to me. I thought other things used get_version.py but in searching, I only found update_docs.sh using it. LGTM.

@dhermes dhermes merged commit 6ce152c into googleapis:master Aug 30, 2016
@dhermes dhermes deleted the remove-non-rtd-sphinx branch August 30, 2016 15:36
@dhermes dhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Oct 21, 2023
…orm/python-docs-samples#2219)

* Move import statements into tagged regions

So they will show up in context on web pages.

* Flake8 didn't like needless enums imports

I have to admit, it's right. It's clearer now.
parthea added a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants