Skip to content

Conversation

@daspecster
Copy link
Contributor

Update navigation and glcoud references.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 8, 2016
@daspecster daspecster force-pushed the updates-from-rename-2 branch from 6e3c4c3 to 56c299f Compare September 8, 2016 16:41
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 8, 2016
@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

Can you give a preview of the new homepage?

@daspecster
Copy link
Contributor Author

daspecster commented Sep 8, 2016

Site: http://daspecster.github.io/google-cloud-python
Sphinx theme: http://daspecster.github.io/google-cloud-python/latest/

I just noticed that when you click "Read the docs" the dropdown for switching languages has the wrong links in it.

@daspecster
Copy link
Contributor Author

@dhermes, how does this look?

@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

LGTM, maybe squash commits?

ASIDE: Could you explain what happened to home.html / how much of it remains / what did it do eventually?

@daspecster daspecster force-pushed the updates-from-rename-2 branch from 35b0ab2 to 511b343 Compare September 8, 2016 22:01
@daspecster
Copy link
Contributor Author

Squshed!

home.html is for the gcloud-common doc site. It's location and name are defined in the manifest.json.

The src and json folders are all that's left from the gcloud-common site.
I can remove those as well if you want but I'll need to get our repo removed from 'deploy-docs.sh`.

@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

@daspecster I'd say you should proceed as follows (in order):

  1. Remove our repo from deploy-docs.sh
  2. Remove the src and json folders (and anything else that's dead) from gh-pages and do it in this PR

@daspecster
Copy link
Contributor Author

daspecster commented Sep 8, 2016

@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

@daspecster It seems that versions.html should stick around for old docsets:
https://googlecloudplatform.github.io/google-cloud-python/versions.html

@daspecster
Copy link
Contributor Author

@dhermes I added versions.html back and updated the links.
I'll squash before merging if this looks good?

@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

LGTM. No need to squash, in that it could be painful.

Regarding the updating of versions.html, it's kind of the same idea as old docs versions. If they break, they break and that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants