Skip to content

Logging: s/print/logging.info/ #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Logging: s/print/logging.info/ #5569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions logging/google/cloud/logging/handlers/transports/background_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import atexit
import logging
import sys
import threading
import time

Expand Down Expand Up @@ -195,7 +196,9 @@ def stop(self, grace_period=None):
self._queue.put_nowait(_WORKER_TERMINATOR)

if grace_period is not None:
print('Waiting up to %d seconds.' % (grace_period,))
print(
'Waiting up to %d seconds.' % (grace_period,),
file=sys.stderr)

self._thread.join(timeout=grace_period)

Expand All @@ -216,12 +219,15 @@ def _main_thread_terminated(self):
if not self._queue.empty():
print(
'Program shutting down, attempting to send %d queued log '
'entries to Stackdriver Logging...' % (self._queue.qsize(),))
'entries to Stackdriver Logging...' % (self._queue.qsize(),),
file=sys.stderr)

if self.stop(self._grace_period):
print('Sent all pending logs.')
print('Sent all pending logs.', file=sys.stderr)
else:
print('Failed to send %d pending logs.' % (self._queue.qsize(),))
print(
'Failed to send %d pending logs.' % (self._queue.qsize(),),
file=sys.stderr)

def enqueue(self, record, message, resource=None, labels=None):
"""Queues a log entry to be written by the background thread.
Expand Down