From 5bb3ac3748814596b780c12dae1dd7c76c99d49b Mon Sep 17 00:00:00 2001 From: Joe Wang Date: Wed, 22 Nov 2023 09:57:14 -0500 Subject: [PATCH] fix lint --- .../appengine/http/UrlFetchTransport.java | 13 ++++++------- .../com/google/api/client/http/HttpTransport.java | 4 +--- .../api/client/http/javanet/NetHttpTransport.java | 3 +-- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/google-http-client-appengine/src/main/java/com/google/api/client/extensions/appengine/http/UrlFetchTransport.java b/google-http-client-appengine/src/main/java/com/google/api/client/extensions/appengine/http/UrlFetchTransport.java index 57496f19d..fdc810de6 100644 --- a/google-http-client-appengine/src/main/java/com/google/api/client/extensions/appengine/http/UrlFetchTransport.java +++ b/google-http-client-appengine/src/main/java/com/google/api/client/extensions/appengine/http/UrlFetchTransport.java @@ -32,13 +32,12 @@ * *

URL Fetch is only available on Google App Engine (not on any other Java environment), and is * the underlying HTTP transport used for App Engine. Their implementation of {@link - * HttpURLConnection} is simply an abstraction layer on top of URL Fetch. By implementing - * transport that directly uses URL Fetch, we can optimize the behavior slightly, and can - * potentially take advantage of features in URL Fetch that are not available in {@link - * HttpURLConnection}. Furthermore, there is currently a serious bug in how HTTP headers are - * processed in the App Engine implementation of {@link HttpURLConnection}, which we are able to - * avoid using this implementation. Therefore, this is the recommended transport to use on App - * Engine. + * HttpURLConnection} is simply an abstraction layer on top of URL Fetch. By implementing transport + * that directly uses URL Fetch, we can optimize the behavior slightly, and can potentially take + * advantage of features in URL Fetch that are not available in {@link HttpURLConnection}. + * Furthermore, there is currently a serious bug in how HTTP headers are processed in the App Engine + * implementation of {@link HttpURLConnection}, which we are able to avoid using this + * implementation. Therefore, this is the recommended transport to use on App Engine. * * @since 1.10 * @author Yaniv Inbar diff --git a/google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java b/google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java index db144516c..a3d23c30b 100644 --- a/google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java +++ b/google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java @@ -157,9 +157,7 @@ public boolean isMtls() { * @throws IOException I/O exception * @since 1.4 */ - public void shutdown() throws IOException { - - } + public void shutdown() throws IOException {} public boolean isShutdown() { return true; diff --git a/google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpTransport.java b/google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpTransport.java index 45bb41e11..064d4dea3 100644 --- a/google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpTransport.java +++ b/google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpTransport.java @@ -38,8 +38,7 @@ /** * Thread-safe HTTP low-level transport based on the {@code java.net} package. * - *

Users should consider modifying the keep alive property on {@link NetHttpTransport} to - * control + *

Users should consider modifying the keep alive property on {@link NetHttpTransport} to control * whether the socket should be returned to a pool of connected sockets. More information is * available here.