Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

feat(samples): add remaining featurestore api samples #974

Merged
merged 8 commits into from
Jul 11, 2022
Merged

feat(samples): add remaining featurestore api samples #974

merged 8 commits into from
Jul 11, 2022

Conversation

sai-chaithu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #945 ☕️

@sai-chaithu sai-chaithu requested a review from a team as a code owner June 23, 2022 14:56
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 23, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 23, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jun 23, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. labels Jun 23, 2022
@sai-chaithu sai-chaithu changed the title feat(samples): add featurestore samples feat(samples): add create, get, list, update feature-store samples Jun 23, 2022
@sai-chaithu sai-chaithu changed the title feat(samples): add create, get, list, update feature-store samples feat(samples): add remaining featurestore api samples Jun 23, 2022
dizcology
dizcology previously approved these changes Jun 23, 2022
View reviewed changes
@diemtvu diemtvu self-assigned this Jun 24, 2022
@diemtvu diemtvu added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2022
diemtvu
diemtvu previously approved these changes Jun 24, 2022
View reviewed changes
@sai-chaithu sai-chaithu requested a review from a team as a code owner June 24, 2022 12:51
@diemtvu diemtvu added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot dismissed stale reviews from diemtvu and dizcology June 24, 2022 13:28

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 24, 2022
@diemtvu diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2022
diemtvu
diemtvu reviewed Jun 28, 2022
View reviewed changes
samples/snippets/src/main/java/aiplatform/GetFeaturestoreSample.java Outdated
}
}
}
// [END aiplatform_get_featurestore_sample]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at the end of the file, here and else where

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the files as suggested

@diemtvu diemtvu added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2022
@gcf-merge-on-green gcf-merge-on-green bot dismissed dizcology’s stale review July 4, 2022 12:52

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 4, 2022
@diemtvu diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2022
@alicejli
Copy link
Contributor

alicejli commented Jul 8, 2022

@dizcology do you mind re-reviewing this? Thanks!

@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@kurtisvg kurtisvg removed their assignment Jul 11, 2022
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@alicejli alicejli added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@alicejli alicejli merged commit 872efb4 into googleapis:main Jul 11, 2022
@release-please release-please bot mentioned this pull request Jul 11, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 3.1.0 (#988)
0c21a55 
🤖 I have created a release *beep* *boop*
---


## [3.1.0](v3.0.0...v3.1.0) (2022-07-13)


### Features

* **samples:** add remaining featurestore api samples ([#974](#974)) ([872efb4](872efb4))
* **samples:** added all entity type samples ([#976](#976)) ([b75963f](b75963f))


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-aiplatform/issues/1485)) ([#991](#991)) ([858e68b](858e68b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to googleapis/google-cloud-java that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 3.1.0 (#988)
805379a 
🤖 I have created a release *beep* *boop*
---


## [3.1.0](googleapis/java-aiplatform@v3.0.0...v3.1.0) (2022-07-13)


### Features

* **samples:** add remaining featurestore api samples ([#974](googleapis/java-aiplatform#974)) ([99ea51d](googleapis/java-aiplatform@99ea51d))
* **samples:** added all entity type samples ([#976](googleapis/java-aiplatform#976)) ([f496d8a](googleapis/java-aiplatform@f496d8a))


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-aiplatform/issues/1485)) ([#991](googleapis/java-aiplatform#991)) ([c41d394](googleapis/java-aiplatform@c41d394))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alicejli alicejli alicejli approved these changes

@diemtvu diemtvu diemtvu approved these changes

@dizcology dizcology dizcology approved these changes

Assignees

@diemtvu diemtvu

Labels
api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sample snippets for Vertex Feature Store
6 participants
@sai-chaithu @alicejli @dizcology @diemtvu @kurtisvg @yoshi-kokoro