Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Code snippet for City class does not match Android Java version #876

Open
paulsmithkc opened this issue Feb 16, 2022 · 4 comments · May be fixed by #877
Open

Docs: Code snippet for City class does not match Android Java version #876

paulsmithkc opened this issue Feb 16, 2022 · 4 comments · May be fixed by #877
Labels
api: firestore Issues related to the googleapis/java-firestore API. documentation Improvements or additions to documentation type: docs Improvement to the documentation for an API.

Comments

@paulsmithkc
Copy link

paulsmithkc commented Feb 16, 2022 •
edited
Loading

Environment details

Documentation on https://firebase.google.com/

Steps to reproduce

  1. Open the Add data to Cloud Firestore page in the docs.
  2. Compare the "Java" and "Java Android" code snippets under Custom objects
  3. Notice that there a significant inconsistencies, and that both versions only show part of the class.

External references such as API reference guides

Any additional information below

Related issue on Android snippet firebase/snippets-android#322

See pull request #877
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Feb 16, 2022
@paulsmithkc paulsmithkc changed the title Docs: Example code for City class does not match Android Java version Docs: Code snippet for City class does not match Android Java version Feb 16, 2022
This was referenced Feb 16, 2022
Closed
Open
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 17, 2022
@ehsannas
Copy link
Contributor

@morganchen12 Can you please triage this and review @paulsmithkc 's contribution (#877) ?

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 21, 2022
@morganchen12
Copy link

@ehsannas the change LGTM. I'm not an owner for this repo so I can't approve/merge, @schmidt-sebastian probably can.

@ehsannas
Copy link
Contributor

Thanks

@schmidt-sebastian
Copy link
Contributor

Going to merge based on Morgan's review.

@meredithslota meredithslota added type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2022
@ehsannas ehsannas added the documentation Improvements or additions to documentation label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/java-firestore API. documentation Improvements or additions to documentation type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(java): syncing java and android snippets paulsmithkc/java-firestore
6 participants
@ehsannas @morganchen12 @meredithslota @paulsmithkc @schmidt-sebastian @yoshi-automation