Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove DocumentReference special case in cursor #1396

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Remove DocumentReference special case in cursor #1396

wants to merge 6 commits into from
+7 −56

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Aug 15, 2023 •
edited
Loading

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Aug 15, 2023
@milaGGL milaGGL changed the title remove DocumentReference special case Fix: Remove DocumentReference special case Aug 15, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 15, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@milaGGL milaGGL changed the title Fix: Remove DocumentReference special case Fix: Remove DocumentReference special case in cursor Aug 15, 2023
@milaGGL milaGGL changed the title Fix: Remove DocumentReference special case in cursor fix: Remove DocumentReference special case in cursor Aug 15, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 5, 2023
@milaGGL milaGGL marked this pull request as ready for review October 5, 2023 15:20
@milaGGL milaGGL requested a review from a team as a code owner October 5, 2023 15:20
@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@milaGGL milaGGL requested a review from ehsannas October 5, 2023 16:07
@milaGGL milaGGL added kokoro:run Add this label to force Kokoro to re-run the tests. and removed do-not-merge labels Oct 5, 2023
@milaGGL milaGGL self-assigned this Oct 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas Awaiting requested review from ehsannas

At least 1 approving review is required to merge this pull request.

Assignees

@milaGGL milaGGL

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @ehsannas @yoshi-kokoro