This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
docs(samples): add UpdateUserEventsJson implementation #388
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,8 @@ | |
| package events; | ||
|
|
||
| import com.google.api.gax.rpc.InvalidArgumentException; | ||
| import com.google.api.gax.rpc.PermissionDeniedException; | ||
| import com.google.cloud.ServiceOptions; | ||
| import com.google.cloud.retail.v2.GcsSource; | ||
| import com.google.cloud.retail.v2.ImportErrorsConfig; | ||
| import com.google.cloud.retail.v2.ImportMetadata; | ||
|
|
@@ -34,91 +34,95 @@ | |
| import com.google.cloud.retail.v2.UserEventServiceClient; | ||
| import com.google.longrunning.Operation; | ||
| import com.google.longrunning.OperationsClient; | ||
| import java.io.IOException; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| public class ImportUserEventsGcs { | ||
|
|
||
| public static void main(String[] args) throws IOException, InterruptedException { | ||
| String projectId = ServiceOptions.getDefaultProjectId(); | ||
| String defaultCatalog = | ||
| String.format("projects/%s/locations/global/catalogs/default_catalog", projectId); | ||
| String bucketName = System.getenv("EVENTS_BUCKET_NAME"); | ||
| String gcsUserEventsObject = "user_events.json"; | ||
| // TO CHECK ERROR HANDLING USE THE JSON WITH INVALID USER EVENT: | ||
| // gcsEventsObject = "user_events_some_invalid.json" | ||
|
|
||
| importUserEventsFromGcs(defaultCatalog, bucketName, gcsUserEventsObject); | ||
| } | ||
|
|
||
| public static void importUserEventsFromGcs( | ||
| String defaultCatalog, String bucketName, String gcsUserEventsObject) | ||
| throws IOException, InterruptedException { | ||
| String gcsBucket = String.format("gs://%s", bucketName); | ||
| String gcsErrorsBucket = String.format("%s/error", gcsBucket); | ||
|
|
||
| GcsSource gcsSource = | ||
| GcsSource.newBuilder() | ||
| .addInputUris(String.format("%s/%s", gcsBucket, gcsUserEventsObject)) | ||
| .build(); | ||
|
|
||
| UserEventInputConfig inputConfig = | ||
| UserEventInputConfig.newBuilder().setGcsSource(gcsSource).build(); | ||
|
|
||
| System.out.println("GRS source: " + gcsSource.getInputUrisList()); | ||
|
|
||
| ImportErrorsConfig errorsConfig = | ||
| ImportErrorsConfig.newBuilder().setGcsPrefix(gcsErrorsBucket).build(); | ||
|
|
||
| ImportUserEventsRequest importRequest = | ||
| ImportUserEventsRequest.newBuilder() | ||
| .setParent(defaultCatalog) | ||
| .setInputConfig(inputConfig) | ||
| .setErrorsConfig(errorsConfig) | ||
| .build(); | ||
| System.out.printf("Import user events from google cloud source request: %s%n", importRequest); | ||
|
|
||
| // Initialize client that will be used to send requests. This client only | ||
| // needs to be created once, and can be reused for multiple requests. After | ||
| // completing all of your requests, call the "close" method on the client to | ||
| // safely clean up any remaining background resources. | ||
| try (UserEventServiceClient serviceClient = UserEventServiceClient.create()) { | ||
|
There was a problem hiding this comment. Make sure to include the comment regarding client best practices. |
||
| String operationName = serviceClient.importUserEventsCallable().call(importRequest).getName(); | ||
|
|
||
| System.out.println("The operation was started."); | ||
| System.out.printf("OperationName = %s%n", operationName); | ||
|
|
||
| OperationsClient operationsClient = serviceClient.getOperationsClient(); | ||
| Operation operation = operationsClient.getOperation(operationName); | ||
|
|
||
| long assuredBreak = System.currentTimeMillis() + 60000; // 60 seconds delay | ||
|
|
||
| while (!operation.getDone() || System.currentTimeMillis() < assuredBreak) { | ||
| System.out.println("Please wait till operation is done."); | ||
| TimeUnit.SECONDS.sleep(30); | ||
| operation = operationsClient.getOperation(operationName); | ||
| } | ||
|
|
||
| if (operation.hasMetadata()) { | ||
| ImportMetadata metadata = operation.getMetadata().unpack(ImportMetadata.class); | ||
| System.out.printf( | ||
| "Number of successfully imported events: %s%n", metadata.getSuccessCount()); | ||
| System.out.printf( | ||
| "Number of failures during the importing: %s%n", metadata.getFailureCount()); | ||
| } else { | ||
| System.out.println("Metadata is empty."); | ||
| } | ||
|
|
||
| if (operation.hasResponse()) { | ||
| ImportUserEventsResponse response = | ||
| operation.getResponse().unpack(ImportUserEventsResponse.class); | ||
| System.out.printf("Operation result: %s%n", response); | ||
| } else { | ||
| System.out.println("Operation result is empty."); | ||
| } | ||
| } catch (InvalidArgumentException e) { | ||
|
There was a problem hiding this comment. When can this "InvalidArgumentException" happen? Can we add a try/catch for this exception just where it's relevant? There was a problem hiding this comment. It's relevant in that case when bucket has no specified file. |
||
| System.out.printf( | ||
| "%s%n'%s' file does not exist in the bucket. Please " | ||
| + "make sure you have followed the setting up instructions.", | ||
| e.getMessage(), gcsUserEventsObject); | ||
| } catch (PermissionDeniedException e) { | ||
| System.out.println(e.getMessage()); | ||
| } | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just be a separate test in your tests file. You can have one where you call a valid file (e.g.
importUimportUserEventsFromGcs("your-catalog", "user-events.json) and one where you call an invalid file (e.g.importUimportUserEventsFromGcs("your-catalog", "some-invalid-file.json). You shouldn't be depending on someone to edit a comment out, because that means it's not being run the in the CI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.