-
Notifications
You must be signed in to change notification settings - Fork 16
docs(samples): added samples and tests for BigQuery export RPCs #782
Conversation
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few comments.
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/CreateBigQueryExport.java
Outdated
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/UpdateBigQueryExport.java
Outdated
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/CreateBigQueryExport.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed this PR as part of the onboarding process to become a java-samples reviewer. @kurtisvg can you shadow review my reviews on this PR?
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/CreateBigQueryExport.java
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/CreateBigQueryExport.java
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/CreateBigQueryExport.java
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/DeleteBigQueryExport.java
Show resolved
Hide resolved
...va/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/ListBigQueryExports.java
Outdated
Show resolved
Hide resolved
...ippets/src/test/java/com/google/cloud/examples/securitycenter/snippets/BigQueryExportIT.java
Show resolved
Hide resolved
...ippets/src/test/java/com/google/cloud/examples/securitycenter/snippets/BigQueryExportIT.java
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/CreateBigQueryExport.java
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/CreateBigQueryExport.java
Show resolved
Hide resolved
...a/com/google/cloud/examples/securitycenter/snippets/bigqueryexport/UpdateBigQueryExport.java
Outdated
Show resolved
Hide resolved
…gquery-export-samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. It seems like some tests are failing. PTAL!
Memo:
From .kokoro/presubmit/samples.cfg :
|
The kokoro configuration looks correct. It will work with multiple keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.6...v2.6.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-securitycenter/issues/1440)) ([#831](#831)) ([c9e86b6](c9e86b6)) * Add connection and description field to finding's list of attributes ([eddf09a](eddf09a)) * Add iam_binding field to findings attributes. It represents particular IAM bindings, which captures a member's role addition, removal, or state ([eddf09a](eddf09a)) * Add next_steps field to finding's list of attributes ([eddf09a](eddf09a)) * AuditConfig for IAM v1 ([eddf09a](eddf09a)) ### Documentation * **samples:** added samples and tests for BigQuery export RPCs ([#782](#782)) ([279624f](279624f)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.10.10 ([#823](#823)) ([033d05a](033d05a)) * update dependency com.google.cloud:google-cloud-bigquery to v2.11.0 ([#824](#824)) ([6cb75b3](6cb75b3)) * update dependency com.google.cloud:google-cloud-bigquery to v2.11.1 ([#827](#827)) ([794bd01](794bd01)) * update dependency com.google.cloud:google-cloud-bigquery to v2.11.2 ([#828](#828)) ([4b4b2df](4b4b2df)) * update dependency com.google.cloud:google-cloud-pubsub to v1.117.0 ([#825](#825)) ([6685899](6685899)) * update dependency com.google.cloud:google-cloud-pubsub to v1.118.0 ([#829](#829)) ([1af1799](1af1799)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#830](#830)) ([602eb69](602eb69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-securitycenter@v2.5.6...v2.6.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-securitycenter/issues/1440)) ([#831](googleapis/java-securitycenter#831)) ([228f74c](googleapis/java-securitycenter@228f74c)) * Add connection and description field to finding's list of attributes ([76cfbce](googleapis/java-securitycenter@76cfbce)) * Add iam_binding field to findings attributes. It represents particular IAM bindings, which captures a member's role addition, removal, or state ([76cfbce](googleapis/java-securitycenter@76cfbce)) * Add next_steps field to finding's list of attributes ([76cfbce](googleapis/java-securitycenter@76cfbce)) * AuditConfig for IAM v1 ([76cfbce](googleapis/java-securitycenter@76cfbce)) ### Documentation * **samples:** added samples and tests for BigQuery export RPCs ([#782](googleapis/java-securitycenter#782)) ([3bbab26](googleapis/java-securitycenter@3bbab26)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.10.10 ([#823](googleapis/java-securitycenter#823)) ([3e053aa](googleapis/java-securitycenter@3e053aa)) * update dependency com.google.cloud:google-cloud-bigquery to v2.11.0 ([#824](googleapis/java-securitycenter#824)) ([a3e7c36](googleapis/java-securitycenter@a3e7c36)) * update dependency com.google.cloud:google-cloud-bigquery to v2.11.1 ([#827](googleapis/java-securitycenter#827)) ([a33d75a](googleapis/java-securitycenter@a33d75a)) * update dependency com.google.cloud:google-cloud-bigquery to v2.11.2 ([#828](googleapis/java-securitycenter#828)) ([244d0b3](googleapis/java-securitycenter@244d0b3)) * update dependency com.google.cloud:google-cloud-pubsub to v1.117.0 ([#825](googleapis/java-securitycenter#825)) ([4b7697f](googleapis/java-securitycenter@4b7697f)) * update dependency com.google.cloud:google-cloud-pubsub to v1.118.0 ([#829](googleapis/java-securitycenter#829)) ([4a06182](googleapis/java-securitycenter@4a06182)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#830](googleapis/java-securitycenter#830)) ([e568092](googleapis/java-securitycenter@e568092)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
If you write sample code, please follow the samples format.