refactor: use java.time.Duration in Connection API #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use java.time.Duration internally in the Connection API, as that is the value that is used in the public API of Connection. For example, the `Connection#setMaxCommitDelay(java.time.Duration)` method uses this type in the public API. Refactoring the internal classes to also use this type makes it easier to plug these properties into a generic framework for connection state.
product-auto-label
bot
added
size: xl
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rahul2393
approved these changes
Sep 12, 2024
lqiu96
pushed a commit
that referenced
this pull request
Sep 19, 2024
Use java.time.Duration internally in the Connection API, as that is the value that is used in the public API of Connection. For example, the `Connection#setMaxCommitDelay(java.time.Duration)` method uses this type in the public API. Refactoring the internal classes to also use this type makes it easier to plug these properties into a generic framework for connection state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
java.time.Durationinternally in the Connection API, as that is the value that is used in the public API of Connection. For example, theConnection#setMaxCommitDelay(java.time.Duration)method uses this type in the public API.Refactoring the internal classes to also use this type makes it easier to plug these properties into a generic framework for connection state.
This pull request also cleans up the following:
DurationConverterandPgDurationConverterare combined into one class, as they do the same thing, and were almost duplicate of each other.PgDurationConverter, but was also implicitly supported for GoogleSQL durations when they were specified as part of the connection URL. E.g. addingmaxCommitDelay=100in the connection URL was already allowed, and is interpreted as 100ms.This pull request is a pre-requisite for #3322