Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

chore: test on node 10 #43

Merged
merged 4 commits into from
May 17, 2018
Merged

chore: test on node 10 #43

merged 4 commits into from
May 17, 2018

Conversation

alexander-fenster
Copy link
Contributor

Test on Node 10. This PR is created manually (because of some incompatible changes to the Circle config in this repo).

Test on Node 10. This PR is created manually (because of some incompatible changes to the Circle config in this repo).
@alexander-fenster
Copy link
Contributor Author

It's broken now because of grpc/grpc-node#307, I'm not sure if the update is going to be released fast enough.

@codecov-io
Copy link

codecov-io commented May 17, 2018

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files           8        8           
  Lines        1473     1473           
  Branches       62       62           
=======================================
  Hits         1453     1453           
  Misses         10       10           
  Partials       10       10
Impacted Files Coverage Δ
test/service.ts 98.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0d018...efd9bae. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit e1e9939 into master May 17, 2018
@jmdobry jmdobry deleted the test-on-node10 branch October 16, 2018 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants