fix: Remove @internal annotation from snapshot_ #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
TheIronDev
force-pushed
the
tystark/make-snapshot_-non-internal
branch
from
c3ade40
to
982e90b
Compare
TheIronDev
changed the title
|
Is there an appropriate person I should ping for review? 🐼 |
There was a problem hiding this comment.
LGTM. I'm not seeing nodejs-firestore make use of the @internal flag anyway. Perhaps something downstream is honoring the internal flag. The @private annotation and underscore in the name should convey the nature of this member, as something not for public consumption.
This commit removes the @internal annotation from snapshot_, and fixes firebase/firebase-functions-test#87. `snapshot_` is currently referenced [here](https://github.com/firebase/firebase-functions-test/blob/master/src/providers/firestore.ts#L99). [More context here]( firebase/firebase-functions-test#87) I'm happy to work through better alternatives too.
TheIronDev
force-pushed
the
tystark/make-snapshot_-non-internal
branch
from
faefe03
to
5930446
Compare
MarkDuckworth
approved these changes
Sep 14, 2022
MarkDuckworth
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the @internal annotation from snapshot_,
and fixes firebase/firebase-functions-test#87.
snapshot_is currently referenced here.More context here
I'm happy to work through better alternatives too.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes firebase/firebase-functions-test#79 🦕