-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose databaseId getter on Firestore class #1937
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
This seems like a reasonable and simple change. However, since this does affect the API surface, I will need to have this approved internally. Hang on while I handle our internal process for these types of changes. |
Hey. The internal API review is ok with exposing databaseId, but projectId was asked to take a different approach. If you restrict change to just exposing databaseId, I will merge right away. |
@tom-andersen changed |
1 similar comment
@tom-andersen changed |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1936