-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support non-ISO-8859-1 Collection Names in Queries #697
Conversation
Adds tests to verify that we can query non-Ascii collection
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 96.22% 96.09% -0.14%
==========================================
Files 20 20
Lines 2227 2227
Branches 470 470
==========================================
- Hits 2143 2140 -3
- Misses 20 22 +2
- Partials 64 65 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 96.22% 96.09% -0.14%
==========================================
Files 20 20
Lines 2227 2227
Branches 470 470
==========================================
- Hits 2143 2140 -3
- Misses 20 22 +2
- Partials 64 65 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but do we know why the collection path is getting sent as "metadata" in the first place and if that's something we should dig into? Seems like a minor waste of bandwidth if nothing else...?
go/grpc-request-params should answer all your questions. The metadata translates to HTTP headers, which some system at some point will use for something useful. |
Updates google-gax to 1.1.2 to pull in googleapis/gax-nodejs#521 and adds tests to verify that we can query non-Ascii collection.